Commit graph

6753 commits

Author SHA1 Message Date
gregoirenovel
0846bad1c8 Mutualize code in methods
As done in YesNoChamp
2019-01-08 12:32:27 +01:00
gregoirenovel
866c74ce63 Add Champ#for_api 2019-01-08 12:32:27 +01:00
gregoirenovel
083dfb4eaa Improve ProcedureExportService 2019-01-08 12:32:27 +01:00
gregoirenovel
b4781f7440 Make dossier link clickable for users in the Demande tab 2019-01-08 12:32:27 +01:00
gregoirenovel
cc07f0d701 Add a blank line to improve readability 2019-01-08 12:32:27 +01:00
gregoirenovel
e4f10a3d2d Order a case statement alphabetically 2019-01-08 12:32:26 +01:00
gregoirenovel
66c633a1e5 Mutualize some code 2019-01-08 12:32:26 +01:00
gregoirenovel
5014e3f4c1 Move the display logic directly into the carte champ partial 2019-01-08 12:32:26 +01:00
gregoirenovel
dbbe2866d5 Extract the siret champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c1ebae3ee8 Extract the textarea champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
e6e67dab35 Extract multiple_drop_down_list champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
81d6e193e5 Extract the piece_justificative champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c7f2293c15 Extract the dossier_link champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
004cdd4c43 Add highlights to all champs 2019-01-08 12:32:26 +01:00
gregoirenovel
20ea577a66 Remove a case that can be handled by the general case 2019-01-08 12:32:26 +01:00
gregoirenovel
f9df32d72e Use c.to_s instead of value, to avoid confusion 2019-01-08 12:32:26 +01:00
gregoirenovel
f5a31be36a Remove the now useless #formatted_value method 2019-01-08 12:32:26 +01:00
gregoirenovel
c00aac2f80 We can now replace processing in #formatted_value by #to_s calls 2019-01-08 12:32:26 +01:00
gregoirenovel
f27717ab23 Make the CheckboxChamp export similar to YesNoChamp
Previously, nil values would be returned as nil
and not as off
2019-01-08 12:32:26 +01:00
gregoirenovel
4a6930b60a Remove from EngagementChamp a method it’s inheriting 2019-01-08 12:32:26 +01:00
gregoirenovel
66d1b7ba10 Use ternary conditions 2019-01-08 12:32:26 +01:00
gregoirenovel
9e42190148 Remove the proxy value_for_export method
Overload for_export instead
2019-01-08 12:32:26 +01:00
gregoirenovel
7cd50531cf Remove the proxy string_value method
Overload to_s instead
2019-01-08 12:32:26 +01:00
gregoirenovel
9a2341c56c Remove the useless #for_display proxy method 2019-01-08 12:32:26 +01:00
gregoirenovel
2e6c91e9b0 Move #selected_options to the only relevant model 2019-01-08 12:32:26 +01:00
gregoirenovel
c4b9a0b79e Rename DropDownList#selected_options_without_decorator 2019-01-08 12:32:26 +01:00
gregoirenovel
4b4eb6d53e Simplify code 2019-01-08 12:32:26 +01:00
gregoirenovel
16bccb2386 Remove the useless #value_for_export method 2019-01-08 12:32:26 +01:00
Mathieu Magnin
5fab5106cb
Merge pull request #3260 from betagouv/fix-sign-in-layout
layouts: fix styling of the sign_in and sign_up pages
2019-01-08 10:23:59 +01:00
Pierre de La Morinerie
142b684170 layouts: fix styling of the sign_in and sign_up pages
This was broken during the shared layout refactoring
2019-01-08 08:16:55 +01:00
Pierre de La Morinerie
d9acc47562
Merge pull request #3255 from betagouv/fix-send-button
Messagerie : corrige l'affichage du bouton "Envoyer" sur mobile
2019-01-07 16:35:45 +01:00
Pierre de La Morinerie
be1567ecbd messages: improve wording of the "Send" button 2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
46b4d3c46b messages: fix Send button being clipped on mobile screens 2019-01-07 16:20:23 +01:00
gregoirenovel
263c94c2b5
Merge pull request #3180 from betagouv/common-demarches-layout
layouts: use a common layout for the demarche overview
2019-01-07 16:19:44 +01:00
Pierre de La Morinerie
0a7b061e70 layouts: move the procedure_context CSS to its own stylesheet 2019-01-07 15:40:19 +01:00
Pierre de La Morinerie
e25bd7139f layouts: use a common procedure_context layout for the demarche overview 2019-01-07 15:39:58 +01:00
Pierre de La Morinerie
5a36546485 layouts: rename "application" to "application_old" 2019-01-07 12:17:05 +01:00
Pierre de La Morinerie
f42af316d9
Merge pull request #3217 from betagouv/clean-gemfile
Clean gemfile
2019-01-07 10:59:41 +01:00
gregoirenovel
c51280c40c Enable the Bundler/OrderedGems cop 2019-01-07 10:34:55 +01:00
gregoirenovel
005eea26f7 Remove the unused web-console gem 2019-01-07 10:34:55 +01:00
gregoirenovel
9302905271 Remove the unused rack-handlers gem 2019-01-07 10:34:55 +01:00
gregoirenovel
7747f40ec0 Sort gems by alphabetic order 2019-01-07 10:34:55 +01:00
gregoirenovel
feae5194fa Use single quotes everywhere in the Gemfile 2019-01-07 10:34:55 +01:00
gregoirenovel
aaff27aca9 Move Gemfile comments into the line they comment
And remove some useless comments
2019-01-07 10:34:55 +01:00
Pierre de La Morinerie
0137a41523
Merge pull request #3236 from betagouv/fix-3235-sendinblue-automation
Fix #3235 sendinblue automation
2019-01-07 10:32:33 +01:00
Chaïb Martinez
144bc86cd0 Add sendinblue tracking in admin backoffice pages 2019-01-07 10:27:50 +01:00
Chaïb Martinez
0452a3046c Add sendinblue tracking in admin backoffice pages 2019-01-07 10:27:50 +01:00
Chaïb Martinez
b04de622c6 Add sendinblue js 2019-01-07 10:27:50 +01:00
Pierre de La Morinerie
356171a28f
Merge pull request #3221 from betagouv/logged-out-improvements
Sign-in screen visual improvements
2019-01-07 10:17:47 +01:00
gregoirenovel
fd2b44b45e Fix the FC info link 2019-01-07 08:52:51 +01:00