simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
...
This reverts commit c902061ebfb4ed11c788
2024-09-19 11:09:01 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods
2024-09-17 10:29:34 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 12:55:59 +02:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one
2024-09-09 11:00:01 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
...
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring"
2024-08-30 16:43:30 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods
2024-08-26 14:53:56 +02:00
Lisa Durand
8722a10d63
fix specs
2024-08-22 17:54:24 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment
2024-08-22 09:26:48 +02:00
mfo
4bf5725d6d
data(backfill): Champs::RnfChamp.value_json [±400 occurences]
2024-08-20 10:31:23 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json
2024-08-20 10:31:23 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories
2024-07-22 13:53:45 +02:00
mfo
4ea601de79
fix(champs.pj.clone): stop cloning private piece_justificative_file when user clone his dossier
2024-05-21 09:50:27 +02:00
Paul Chavard
a1db089681
fix(champ): champ value formatters should check champ type
2024-05-13 17:00:46 +02:00
Paul Chavard
244dcfcc23
refactor(export): improuve specs
2024-04-24 13:27:20 +02:00
Paul Chavard
95bb09a1f8
refactor(champs): do not depend on attributes hash key in old code
2024-04-22 18:38:59 +02:00
Paul Chavard
08e127c120
chore(spec): remove test for old unused behaviour
2024-04-16 12:10:08 +02:00
Paul Chavard
6ad0b901b6
fix(champ): use public_id in views
2024-03-26 11:23:23 +01:00
Paul Chavard
deb19177f7
refactor(test): update tests
2024-03-04 10:59:11 +01:00
Paul Chavard
702b9dd8b3
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 08:54:08 +01:00
Christian Lautier
5ce42afe28
Fix datetime_champ validation with negative time zone
2023-08-02 14:40:47 +02:00
Paul Chavard
5abb6a8f12
chore(spec): remove memory store cache from tests
2023-04-13 13:10:23 +02:00
Paul Chavard
fce78bbf30
feat(dossier): multiselect without react
2023-04-03 16:54:50 +02:00
sebastiencarceles
f52554b5a3
review: update value with async fetch
...
1 - spec cover the job which fetches external data
2 - refactor the job with guard clauses
3 - delegate update operation to the champ itself
4 - annuaire education: override the update operation
to let the value be populated by the fetched data
5 - prefilling: don't fetch data synchronously
2023-02-28 14:53:08 +01:00
Damien Le Thiec
dce4c84f9a
Merge branch 'main' into feature/prefill_repetible
2023-02-16 17:08:30 +01:00
sebastiencarceles
d5ffd61ab6
validate values inclusion
2023-02-16 10:49:15 +01:00
Damien Le Thiec
dbb92e7fd3
Merge branch 'main' into feature/prefill_repetible
2023-02-11 22:40:56 +01:00
Damien Le Thiec
a51ed0094b
Fix tests
2023-02-07 00:28:21 +01:00
Paul Chavard
6924b8e46d
feat(dossier): optional repetition champ should not add first row
2023-02-06 11:53:32 +01:00
Damien Le Thiec
63e7c17fda
First tests for prefill repetition
2023-02-03 12:14:18 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ ( #8442 )
...
* make regions champ prefillable
* add possible and example value
* add external_id and value validation
2023-01-24 11:25:17 +00:00
Damien Le Thiec
5e26acb0e1
Make date and datetime prefillable ( #8304 )
...
* Make date and datetime prefillable
* Format in ISO8601 format
2023-01-12 17:42:02 +01:00
Paul Chavard
af33d5d65c
refactor(repetition): use row_id instead of row
2023-01-10 19:31:41 +01:00
Sébastien Carceles
fa6fc077b4
normalize boolean values ( #8320 )
...
* extract parent for yes no and checkbox champs
* checkbox stores true / false instead of on / off
* normalize blank value to nil
* normalize invalid value to false
* after party task: normalize checkbox values
* after party task: normalize yes_no values
2023-01-05 11:18:27 +00:00
Paul Chavard
00218fded2
fix(dossier): update spec
2022-12-21 14:03:02 +01:00
Paul Chavard
1b95809f14
refactor(dossier): flatten champ attributes
2022-12-14 13:03:06 +01:00
Colin Darie
b8296c6d4d
feat(piece_justificative): supports multiple files
...
Closes #7924
2022-12-05 10:47:10 +01:00
Paul Chavard
29bdd82b59
refactor(procedure): types_de_champ -> active_revision.types_de_champ_public
2022-11-17 13:54:14 +01:00
Paul Chavard
e6288c39f2
refactor(dossier): champs -> champs_public
2022-11-10 22:44:39 +00:00
Martin
17ed80b18a
clean(Champs::Engagement): migrate to Champs::Checkbox, some for TypeDeChamp
2022-09-27 19:09:28 +02:00
simon lehericey
ac0ac171ad
perf(dossier): remove unused row validation
...
Gain, one request per champ not child
2022-09-07 15:00:40 +02:00
Colin Darie
4ece7c2494
fix(champ): remove null byte before save
...
Les null bytes peuvent être injectés lors de c/c depuis certains documents,
et ne sont pas sauvegardables en base, rendant la sauvegarde d'un dossier impossible.
Closes #7656
https://sentry.io/organizations/demarches-simplifiees/issues/3194932607/activity/?project=1429550&query=is%3Aunresolved
2022-08-31 11:39:34 +02:00
simon lehericey
5ebaf59fdb
parent_id -> parent_stable_id
2022-07-05 11:53:18 +02:00
simon lehericey
fd4d543b20
fix test
2022-05-18 15:18:17 +02:00
Paul Chavard
cdd597db19
refactor(dossier): fix champ repetition factories
2022-05-18 11:24:14 +02:00
Paul Chavard
4523c0590c
fix(dossier): champs repetable in champs private
2022-05-04 15:57:25 +02:00
Paul Chavard
c60a8970f1
perf(dossier): memoize champ.sections on dossier
2022-03-11 00:15:53 +01:00
Paul Chavard
a2c53ce7ea
format phone numbers
2021-06-15 09:14:55 +02:00
Pierre de La Morinerie
75a1046315
active_storage: refactor concerns
...
Follow-up of #5953 .
Refactor the concerns with two goals:
- Getting closer from the way ActiveStorage adds its own hooks.
Usually ActiveStorage does this using an `Attachment#after_create`
hook, which then delegates to the blob to enqueue the job.
- Enqueuing each job only once. By hooking on `Attachment#after_create`,
we guarantee each job will be added only once.
We then let the jobs themselves check if they are relevant or not, and
retry or discard themselves if necessary.
We also need to update the tests a bit, because Rails'
`perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on`
clause of jobs. Instead it forwards the exception to the caller – which
makes the test fail.
Instead we use the inline version of `perform_enqueued_jobs()`, without
a block, which properly ignores errors catched by retry_on.
2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
2f948f7e46
active_storage: fix blob update hooks
...
For some reason on Rails 6.1 the `after_update_commit` hook is properly
registered – but disappears from the record later, and in the end is
never run.
Fix it by using the general `after_commit` hook instead.
2021-03-04 14:30:38 +01:00
