mfo
e08aa7d28b
wip(validates): prefill and validate_champ_value? on all other missing validation checks
2024-04-01 07:36:14 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
ff527517c9
fix(Champs::CiviliteChamp): validates Champs::CiviliteChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
94ea16c894
fix(Champs::BooleanChamp): validates Champs::BooleanChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context.
2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup
2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context
2024-04-01 07:07:11 +02:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
...
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257
add validation on decimal max 3 digits after coma
2024-03-27 10:55:10 +01:00
Paul Chavard
6ad0b901b6
fix(champ): use public_id in views
2024-03-26 11:23:23 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
...
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
a726d34404
fix(cloned procedures): reset closing attributes
2024-03-22 17:07:22 +01:00
Eric Leroy-Terquem
30f96a79c2
chore(bulk messages): update associations
2024-03-22 14:52:34 +01:00
Martin
44cdb14fb9
feat(type_de_champ_editor): move champs after another champ.
2024-03-22 10:10:28 +01:00
Martin
015e606f50
fix(dossier.has_many.france_connect_informations): wip
2024-03-22 07:47:02 +01:00
mfo
d00b146dc3
Merge pull request #10165 from mfo/US/add_champ_descriptor_id
...
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 17:05:56 +00:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
...
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
9139bfbf48
clean(administrateur): remove dead code
2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
6a77bbb6c9
fix(administrateur): can be deleted only if other admin or dossiers on all procedures included with discarded
2024-03-21 14:27:52 +01:00
Colin Darie
2f4444bd5e
chore: mark preferred domain to new domain when closing notice
2024-03-21 13:15:34 +01:00
Colin Darie
a16f88f8af
chore(schema): add preferred_domain to users
2024-03-21 12:21:19 +01:00
simon lehericey
a42f85ef05
remove useless administration_id in invite_admin and invite_administrateur!
2024-03-21 11:54:02 +01:00
Martin
22fa2e61b4
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 10:29:33 +01:00
simon lehericey
4c3b0229eb
set Current.application_base_url
2024-03-21 10:06:09 +01:00
simon lehericey
72a2b764dc
add demarches.gouv.fr as sender of automatic emails
2024-03-21 10:06:09 +01:00
simon lehericey
d13910dac4
set Current.contact_email
2024-03-21 10:06:09 +01:00
simon lehericey
efa35e04a5
use Current.application_name in app excluding mail
2024-03-21 10:06:09 +01:00
simon lehericey
b9fcb25f1a
set Current.application_name
2024-03-21 10:06:08 +01:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
...
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
...
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
...
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
280f1ac3c7
refactor(procedure): add a prefix to closing_reason enum
2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4
fix(procedure): validates presence of replaced_by_id if procedure redirected
2024-03-20 14:04:59 +01:00
Paul Chavard
eff03aaf23
refactor(dossier): label indexes based on type_de_champ not champ
2024-03-20 09:58:47 +01:00
Paul Chavard
33125c691e
Merge pull request #10145 from tchak/fix-clone-with-stable-id
...
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-20 08:29:12 +00:00
simon lehericey
df0298ac42
simply deal with multiple agent_connect_information by taking the last used
2024-03-19 21:17:45 +01:00
simon lehericey
ca17524559
Allow instructeur to have multiple agent_connect_information
...
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
4997a81639
remove one indirection
2024-03-19 21:17:44 +01:00
Paul Chavard
a962e2d94e
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-18 20:04:53 +01:00
Paul Chavard
c5892a1ca2
Merge pull request #10141 from tchak/fix-rows-order
...
fix(champs): fix rows order
2024-03-18 16:56:21 +00:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
...
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Paul Chavard
818dcc32da
fix(champs): fix rows order
2024-03-18 17:26:41 +01:00
Lisa Durand
72c4b23821
add last_champ_updated_at in export
2024-03-18 16:10:26 +01:00
Kara Diaby
e73318e3bb
Merge pull request #10127 from demarches-simplifiees/feat/10005
...
ETQ expert, je veux pouvoir gérer les notifications que je reçois depuis mon interface
2024-03-18 12:27:37 +00:00
Kara Diaby
f41dcc69d8
model
2024-03-18 11:50:29 +00:00
Lisa Durand
b8cf19337f
Merge pull request #10131 from demarches-simplifiees/wording-page-stats-ldu
...
ETQ instructeur je souhaite mieux comprendre le graph "avancée des dossiers" en changeant le terme "démarrés"
2024-03-18 11:49:20 +00:00
Paul Chavard
1b2315cd45
fix(champ): fix multiple champ copies bug
2024-03-18 12:13:22 +01:00
Paul Chavard
8abe3fce79
add stable_id and stream
2024-03-18 11:34:55 +01:00
Lisa Durand
6b916493cb
change wording on page stats
2024-03-18 10:39:11 +01:00
Eric Leroy-Terquem
94f37b6708
Merge pull request #10125 from demarches-simplifiees/destroy-procedure-without-administrateur-and-without-dossier
...
Correctif : supprime les démarches sans administrateur ni dossier
2024-03-18 08:48:52 +00:00
Paul Chavard
900db5624f
refactor(champs): if champ not found - build it
2024-03-17 23:51:45 +01:00
Eric Leroy-Terquem
eae149f49d
chore(administrateur): destroy procedure if no administrateur and no dossier
2024-03-15 16:16:10 +01:00
simon lehericey
277ac1259a
feat(file retrieval): create agent connect information
2024-03-15 14:35:14 +01:00
Lisa Durand
e757eefd37
add message when path is already taken when publishing a procedure
2024-03-14 17:17:47 +01:00
Colin Darie
a8a23f55a6
Merge pull request #10097 from colinux/fix-email-event-with-invalid-to-fields
...
Tech: pas d'erreur EmailEvent lorsque le message ne peut pas avoir plusieurs destinataires
2024-03-12 15:29:52 +00:00
Colin Darie
fc1c6bb412
Merge pull request #10103 from tchak/dossier-vide-from-procedure
...
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 15:29:24 +00:00
Colin Darie
ee92668611
Merge pull request #9930 from demarches-simplifiees/add-external-link-to-procedure
...
ETQ admin lorsque je clos une démarche je peux alerter les usagers et je crée une page de fermeture si la démarche n'est pas redirigée dans DS
2024-03-12 15:03:30 +00:00
Colin Darie
a5c142a702
Merge pull request #10101 from mfo/fix-merge-fork
...
fix(rebase): destroy_all to cascade on dependencies
2024-03-12 14:51:49 +00:00
Paul Chavard
aa0aea1543
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 14:23:07 +01:00
Colin Darie
5f826cfd88
Merge pull request #10095 from demarches-simplifiees/fix_multiple_error_message_on_regexp
...
Admin: corrige un bug ou un message d'erreur d expression regulière apparaissait plusieurs fois
2024-03-12 13:07:25 +00:00
Martin
064f926428
fix(rebase): destroy_all to cascade on dependencies (destroy geoareas)
2024-03-12 11:39:00 +01:00
Eric Leroy-Terquem
c95f0f1cad
feat(procedure): send notifications after closing
2024-03-11 15:48:28 +01:00
Paul Chavard
a865e00f4d
fix(apply_diff): one more time
2024-03-11 15:13:56 +01:00
Colin Darie
de56eadb43
fix(email): don't fail when to header is invalid when email contains <
2024-03-11 13:11:25 +01:00
simon lehericey
2bec15b78f
fix multiple error message on regexp
2024-03-11 11:41:31 +01:00
Paul Chavard
9afe71529e
fix(addresse): lookup for city, departement and region name in local db
2024-03-11 10:49:56 +01:00
Paul Chavard
72e27eb7b4
fix(dossier): safely remove child champs in apply_diff
2024-03-11 09:17:03 +01:00
mfo
14266232a4
Merge pull request #10084 from mfo/US/fix-rebase-when-repetition-was-removed
...
fix(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes
2024-03-08 16:15:00 +01:00
Martin
4a26b61d1b
fix(rebase): rebase a dossier when its repetition had been removed on newer version does not crash
2024-03-08 15:55:50 +01:00
Paul Chavard
6ec7a87bcb
Merge pull request #10080 from demarches-simplifiees/add-dependent-destroy-on-contact-information
...
Correctif : supprime l'information de contact à la suppression du groupe instructeur
2024-03-08 12:15:27 +00:00
Martin
9425f2cc58
fix(user.france_connect_informations): has_many, not has_one
2024-03-08 09:44:21 +01:00
krichtof
1024557081
Merge pull request #10041 from demarches-simplifiees/10029-filter-kind-usager
...
ETQ admin, je peux filtrer toutes les démarches par type d'usager
2024-03-08 08:23:26 +00:00
Eric Leroy-Terquem
6651b36fe4
db(migration): add closing_reason and closing_details to procedure
2024-03-07 19:00:46 +01:00
Eric Leroy-Terquem
877e1f79cc
fix(groupe instructeur): add a dependent destroy on contact information
2024-03-07 16:33:17 +01:00
Paul Chavard
3b13595a41
Merge pull request #10027 from mfo/US/input-state-valid-after-update
...
correctif(Champs::Civilite): ETQ usager, j'aimerais que le champs de type civilité ait le même style d'erreur que les autres
2024-03-07 14:03:06 +00:00
simon lehericey
8dea936d41
double callback on FC based on the request host
2024-03-07 12:14:58 +01:00
Martin
0519dece96
fix(Champs::Civilite): fix dsfr missing red feedback, add green feedback
2024-03-06 15:56:36 +01:00
Eric Leroy-Terquem
418bb8c00f
fix(attestation depot): define organisme on contact_information as on service
2024-03-06 10:47:19 +01:00
Eric Leroy-Terquem
43e870e9ec
fix(attestation depot): run routing engine before sending notifications
2024-03-06 10:47:19 +01:00
Paul Chavard
1243cfefeb
fix(entreprise): graphql effectif
2024-03-05 16:00:28 +01:00
Paul Chavard
a247ec6c12
Merge pull request #9695 from tchak/use-types-de-champ-as-source-of-truth
...
refactor(dossier): use revision as source of truth to diplay champs
2024-03-04 15:03:02 +00:00
Paul Chavard
662917799b
refactor(dossier): remove champ ordered scope
2024-03-04 10:59:11 +01:00
Paul Chavard
1193c866bf
refactor(dossier): has_annotations?
2024-03-04 10:59:11 +01:00
Paul Chavard
9b26dedab4
refactor(dossier): make new methods arguments named
2024-03-04 10:59:11 +01:00
Paul Chavard
2eb1f54aa1
refactor(dossier_loader): ignore champs from old revisions
2024-03-04 10:59:11 +01:00
Paul Chavard
8687d73a73
refactor(dossier): clone only current revision champs
2024-03-04 10:59:11 +01:00
Paul Chavard
1850d80b82
refactor(dossier): use new champs_for_revision method
2024-03-04 10:59:11 +01:00
Paul Chavard
f7758d0033
refactor(dossier): remove old section code
2024-03-04 10:59:11 +01:00
Paul Chavard
02591da16b
refactor(section): update section components
2024-03-04 10:59:11 +01:00
Paul Chavard
283ee72d51
refactor(dossier): implement champs_for_revision
2024-03-04 10:59:11 +01:00
Paul Chavard
6a69b350f7
fix(address): nullify data when empty or invalid address is entered
2024-03-04 09:06:50 +01:00
Paul Chavard
9280ccc23d
Merge pull request #10059 from colinux/improve-flipper
...
Tech: réduit l'impact de Flipper sur la base
2024-03-04 07:18:42 +00:00
Paul Chavard
c52688e1e9
Merge pull request #10056 from tchak/fix-champ-nil
...
fix(dossier): no crash if condition target champ is not found
2024-03-03 09:40:24 +00:00
Colin Darie
dbf04c63a4
fix(flipper): don't clone features globally enabled
2024-03-03 00:13:01 +01:00
Eric Leroy-Terquem
e94ae3498c
Merge pull request #10048 from demarches-simplifiees/etq-admin-je-vois-les-messages-envoyes-aux-brouillons
...
ETQ instructeur je vois les messages envoyés aux usagers avec un dossier en brouillon
2024-03-01 13:27:36 +00:00
Paul Chavard
1e0baca866
fix(dossier): no crach if condition target champ is not found
2024-02-29 22:09:27 +01:00
Paul Chavard
0721c98e65
fix(export): avoid a crash when dossier user is deleted
2024-02-29 17:54:46 +01:00
Eric Leroy-Terquem
1f0e2030be
db(migration): add procedure_id to bulk_messages
2024-02-28 16:07:27 +01:00
Christophe Robillard
26a86d8003
filter all demarches by kind usager
2024-02-23 16:04:27 +01:00
Colin Darie
f04420812b
fix(export): typo tier => tiers
2024-02-22 15:58:29 +01:00
Colin Darie
7143c7e8e2
Merge pull request #9995 from colinux/attestation-v2-improvements
...
ETQ admin, quelques améliorations sur l'éditeur v2
2024-02-22 11:30:41 +00:00
Colin Darie
3c22f4ea48
fix(attestation): always return v1 template when exists, otherwise it's a v2
2024-02-22 12:19:07 +01:00
Colin Darie
8ba1c0e481
feat(attestation): can toggle optional champs tags visibility
2024-02-22 12:19:06 +01:00
Colin Darie
c5174f7d43
feat(attestation): dossier for preview priorize termine dossier: all data are available
2024-02-22 12:19:05 +01:00
Colin Darie
accc5af7d2
chore(tags): don't list champs Carte, PJ, Titre identité
...
Note: ils ne sont pas validés par le TagsValidator, donc ça ne cassera
pas les attestations existantes. L'objectif est juste de ne pas les
proposer dans les interfaces.
2024-02-22 12:19:04 +01:00
Colin Darie
bacfc0c5d1
Merge pull request #10015 from mfo/US/feat-export-include-mandataire
...
ETQ instructeur, ETQ API les exports contiennent plus de donnée (mandataire & info de france connection france connect)
2024-02-22 10:33:15 +00:00
Martin
77927e41bc
feat(api.mandataire): add missing mandataire_first_name/last_name
...
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-21 15:15:55 +01:00
Martin
c2675dfb4d
feat(export.user): add when user passthru FranceConnect or not
2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d
feat(export.for_tier): add to export
2024-02-21 14:44:49 +01:00
Colin Darie
5ab1d45b8a
fix(instructeur): don't crash when adding a filter too long
2024-02-21 12:13:47 +01:00
Paul Chavard
5a8859cd28
Merge pull request #10018 from tchak/fix-address-champ
...
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 09:06:24 +00:00
Colin Darie
1671a783a2
Merge pull request #10021 from colinux/fix-email-subject-double-encode
...
ETQ usager je dois voir de vraies apostrophes à la place de `'` dans les sujets d'email
2024-02-21 08:33:44 +00:00
Paul Chavard
702b9dd8b3
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 08:54:08 +01:00
Colin Darie
c05aaa5f35
fix(email): dynamic subject should be escaped, cf RFC 2047 which have its own encoding
2024-02-20 18:29:41 +01:00
Colin Darie
560d50f52d
fix(dropdown-multiple): a valid option starting by [ may not be a JSON value
2024-02-20 17:41:53 +01:00
Martin
8dc3103ac1
fix(champs.email): allow nil
2024-02-19 15:13:20 +01:00
Paul Chavard
46b12c0c3d
Merge pull request #9990 from tchak/refactor-adresse-champ
...
refactor(address): use directly BAN data
2024-02-16 16:42:17 +00:00
Martin
1a424beb6f
fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken
2024-02-16 14:00:18 +01:00
Paul Chavard
20307f1d21
refactor(address): use directly BAN data
2024-02-16 12:15:14 +01:00
Martin
56ed901703
tech(clean): remove dead code
2024-02-16 11:23:39 +01:00
Martin
3e64a3bbbc
tech(refactor): extract clone logic inside its own class
2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c
refactor(export/archives): holds user profile asking for the archive or export
2024-02-16 11:23:38 +01:00
mfo
4dfb3b86ef
Merge pull request #10000 from mfo/US/groupe-instructeur-manageable-for-routee-procedure
...
ETQ administrateur, je peux gerer la liste des instructeurs même si le routage est activé sur ma démarche
2024-02-16 09:26:06 +00:00
Martin
8488e74bbb
review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
...
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06
feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert
2024-02-15 16:41:00 +01:00
Martin
05193e1d1e
feat(User.validation): validates email when env var is present
2024-02-15 16:41:00 +01:00
Martin
25f92a7760
feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
...
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Martin
5407011668
feat(procedure.routing): allow admin to manage instructeur even when procedure has some routing
2024-02-15 13:40:48 +01:00
seb-by-ouidou
9ddd55d5cd
feat: remove commentaire_component and replace it by message_component + replace commentaires/_form by messages/_form + few fixes
2024-02-15 07:50:20 +00:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
...
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Colin Darie
48644ae407
Merge pull request #9846 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
...
Délégation de compte: ETQ gestionnaire je peux contacter les gestionnaires des groupes parents
2024-02-13 14:42:03 +00:00
Paul Chavard
93635b3516
refactor(logic): compute sub champ values
2024-02-13 11:57:31 +01:00
seb-by-ouidou
fba3cbe331
feat: as gestionnaire, contact gestionnaire of parent groupe
2024-02-13 11:19:52 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf
2024-02-12 17:20:07 +01:00
Lisa Durand
9e3f28e87b
add rnf and rna address in form view
2024-02-12 17:20:05 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address
2024-02-12 15:08:05 +01:00
Colin Darie
6ab3fa1cf4
fix(rubocop): Rails/RedundantActiveRecordAllMethod
2024-02-12 09:33:18 +01:00
Paul Chavard
23592087ae
refactor(instructeur): use precomputed timestamps
2024-02-08 18:36:04 +01:00
Colin Darie
fb14afc530
fix(rna): real RNA identifier could contain at least 1 letter, despite of specs
2024-02-06 15:02:57 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
...
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle
2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9
feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread
2024-02-02 12:52:36 +01:00
Colin Darie
7e02342518
feat(attestation): tiptap default attestation
2024-02-01 18:55:58 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section
2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2
2024-02-01 18:55:50 +01:00
mfo
86fb28bda0
Merge pull request #9956 from mfo/US/amelioration-rebase
...
tech(perf.rebase): améliore la performance pour réconcilier les dossiers d'une procédure lorsqu'un administrateur change le formulaire (donc nouveau milésime 🍷 )
2024-01-31 17:26:25 +00:00
Martin
437b3d2a61
fix(perf): last n+1
2024-01-31 17:06:16 +01:00
Martin
47ff3086af
fix(rebase): preload revision too
2024-01-31 17:06:16 +01:00
Colin Darie
1123222b36
chore(schema): add version to attestation_templates
2024-01-31 17:03:59 +01:00
