mfo
5cba847d10
perf(Instructeurs/Dossiers#demande): remove n+1
2024-10-08 14:47:34 +02:00
simon lehericey
d5a722c143
weird frozen_string bug
2024-10-07 22:09:21 +02:00
simon lehericey
a418cf6632
remove_filter double_write
2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write
2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write
2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write
2024-10-07 22:09:20 +02:00
simon lehericey
0abee08329
add filters for
2024-10-07 22:09:20 +02:00
simon lehericey
3d79c6176e
add columns_ids to procedure_presentations table
2024-10-07 22:09:20 +02:00
simon lehericey
e3697bd976
colonne.id = { procedure_id:, column_id: }.to_json
...
because:
- id should be a string as other id
- id need procedure_id to allow ColumnType.deserialize(id) -> Column as the columns are built by a procedure
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id
2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id
2024-10-07 21:46:59 +02:00
simon lehericey
3c7521a428
extract dossier_id_column, notifications_column
2024-10-07 15:49:58 +02:00
simon lehericey
c6559577f1
remove old comment
2024-10-07 14:50:35 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at
2024-10-05 22:22:04 +02:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
...
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
ecbf985147
refactor(dossier): champs_* -> project_champs_*
2024-10-04 12:05:55 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic
2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
...
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
simon lehericey
fb66434a15
remove empty option at the start of default options
2024-09-30 15:37:02 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text
2024-09-30 15:37:02 +02:00
simon lehericey
5fc0eb11f5
rename remaining drop_down_list_enabled_non_empty_options(other: true) -> drop_down_options_with_other
2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible
2024-09-30 15:37:02 +02:00
simon lehericey
cfb03fc747
remove enabled_non_empty_options indirection
2024-09-30 15:37:01 +02:00
simon lehericey
77b754a08d
no more empty case
2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader
2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods
2024-09-27 11:34:06 +02:00
mfo
75063ae31e
fix(filter): filtering types_de_champs by enum should not ilike. nows it search by exact match since enum are normalized so findable with simple where
2024-09-24 20:48:10 +02:00
mfo
b30cbf3032
tech(doc): explain which columns are ilikable for user/individual
2024-09-24 20:48:09 +02:00
mfo
51ce0cd562
clean(filter): avis column are not filterable, not needed to ilike them
2024-09-24 20:47:43 +02:00
mfo
284bdc5b2b
clean(deadcode): their is no column for avis.label. so clean this one
2024-09-24 20:47:09 +02:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
...
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
...
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
...
closes #9825
2024-09-24 11:28:17 +02:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
...
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
mfo
12ef66c2b0
Merge pull request #10847 from mfo/US/clean-db
...
amélioration : ETQ tech je souhatie que ma base de donnée ne stock pas de donnée inutile
2024-09-24 08:12:09 +00:00
mfo
a71e83dabe
clean(db): remove ignored column
2024-09-24 10:04:04 +02:00
Paul Chavard
b5eb87de6a
fix(champ): improve row_id validation and remove it during export
2024-09-23 17:06:33 +02:00
mfo
7adbdaa4de
tech(clean): unused index and column
2024-09-23 14:53:37 +02:00
Paul Chavard
4ab9ef1f3f
Merge pull request #10842 from tchak/revert-du-revert-de-refactoring-champs
...
Revert "Revert "Merge pull request #10771 ""
2024-09-23 12:27:04 +00:00
Lisa Durand
0272f79c6a
migration to remove hidden_at from dossiers
2024-09-23 10:58:36 +02:00
Paul Chavard
3429a72f53
fix(dossier): do not show repetitions in header sections summary
2024-09-23 10:51:38 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
...
This reverts commit 10a1ae5534
.
2024-09-23 10:21:07 +02:00
Paul Chavard
e4ac781b54
fix(rnf): remove deprecated status attribute
2024-09-20 16:58:51 +02:00
Mathieu Magnin
e9b5c4a615
[ #10837 ] Add an explicit message when SIRET is not valid on service
2024-09-20 15:44:46 +02:00
mfo
cd8c55b161
Merge pull request #10814 from demarches-simplifiees/fix-10813
...
[bug] Ne pas afficher de 500 quand value_json d'un champ SIRET est nil
2024-09-19 15:22:45 +00:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
...
This reverts commit c902061ebf
, reversing
changes made to b4ed11c788
.
2024-09-19 11:09:01 +02:00
LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
...
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
Lisa Durand
3d50f9363f
Merge pull request #10741 from demarches-simplifiees/secu-improve-complexity-password-ldu
...
[sécu] Améliorer la complexité des mots de passe pour tous les users
2024-09-18 12:40:17 +00:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
...
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list
2024-09-18 10:26:00 +02:00
simon lehericey
51e192939c
pack drop_down stuff together
2024-09-18 10:08:12 +02:00
simon lehericey
85684e3bea
homogenize render? if not options
2024-09-18 10:08:12 +02:00
simon lehericey
f1a606da6d
one less indirection
2024-09-18 10:08:12 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value
2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection
2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options
2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[ #10813 ] When value_json of champ SIRET is nil do not crash
2024-09-17 19:05:36 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
...
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
...
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number
2024-09-17 15:18:23 +02:00
Paul Chavard
3fef831524
move child? method for clarity
2024-09-17 10:29:34 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids
2024-09-17 10:29:34 +02:00
Paul Chavard
33e502234e
refactor(dossier loader): simplify all the things
2024-09-17 10:29:34 +02:00
Paul Chavard
2ba356bc68
cleanup(prefill): remove unused validation
2024-09-17 10:29:34 +02:00
Paul Chavard
c94d1b7eea
cleanup: more concistent methods usage
2024-09-17 10:29:34 +02:00
Paul Chavard
a474cf4590
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ
2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage
2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision
2024-09-17 10:29:34 +02:00
Paul Chavard
ed4fbc887a
refactor(dossier): remove unused scopes
2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods
2024-09-17 10:29:34 +02:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
...
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content
2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
...
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Lisa Durand
00a155b896
add password complexity for instructeur, user and password change
2024-09-16 15:23:43 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 12:55:59 +02:00
mfo
7a78fdc913
fix(normalized_address): should not raise an error for addresses without code postal
2024-09-13 11:19:05 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
...
This reverts commit 4289aa2cf5
.
2024-09-13 11:00:08 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
...
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
...
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Mathieu Magnin
a99fae168c
[ #10751 ] Allow sending a new invitation if the user's previous one has expired
2024-09-11 18:45:15 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range
2024-09-10 17:47:50 +02:00
Colin Darie
6240d54fd4
fix: unbreakable space for better look in filters
2024-09-10 12:36:13 +02:00
Colin Darie
40b5eb5ea7
fix: typo region => région
2024-09-10 12:29:53 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization
2024-09-09 16:37:22 +02:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
...
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one
2024-09-09 11:00:01 +02:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
...
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
...
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier
2024-09-06 11:23:12 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥
2024-09-06 08:37:08 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
...
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions
2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen
2024-09-04 15:00:03 +00:00
simon lehericey
eaef5c7e39
readapt name and logic
2024-09-04 08:08:01 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review
2024-09-04 08:05:54 +00:00
Kara Diaby
337f88575d
Modifications sur la méthode after_confirmation dans le modèle user
2024-09-04 08:05:53 +00:00
Kara Diaby
9c41c9a08f
Model FC : au lieu de valider le mail on envoie une demande de confirmation par mail
2024-09-04 08:05:52 +00:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
...
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
simon lehericey
e0daf1032d
rename virtual_dates by non_displayable_dates
2024-09-02 17:27:35 +02:00
simon lehericey
245f7bb975
remove column.virtual params
2024-09-02 17:25:46 +02:00
simon lehericey
3c7c58623f
replace virtual: true
by displayable: false
2024-09-02 17:25:22 +02:00
Lisa Durand
b5051a25d9
it displays an alert if using test service before publishing a procedure
2024-09-02 16:52:21 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p
2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs
2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list
2024-09-02 15:23:11 +02:00
Colin Darie
8e1cfd50dd
feat(procedure): improve dossier_for_preview with last dossier, excluding hidden by user
2024-09-02 15:23:10 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
...
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
...
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring"
2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
37a018880b
chore: generate representations coming from ActionText in background
2024-08-30 16:37:19 +02:00
Eric Leroy-Terquem
00c905a615
chore: generate variant for procedure logo in background
2024-08-30 14:28:42 +02:00
simon lehericey
516205efd9
add path_rewrite model
2024-08-29 16:15:07 +02:00
Paul Chavard
79c9784d17
refactor(dossier loader): simplify all the things
2024-08-26 14:53:56 +02:00
Paul Chavard
bb288337bf
cleanup(prefill): remove unused validation
2024-08-26 14:53:56 +02:00
Paul Chavard
3ef6f450da
cleanup: more concistent methods usage
2024-08-26 14:53:56 +02:00
Paul Chavard
5edb8749c0
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ
2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage
2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision
2024-08-26 14:53:56 +02:00
Paul Chavard
701a28302e
refactor(dossier): remove unused scopes
2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods
2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc
2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ
2024-08-26 11:16:46 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers
2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
...
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
mfo
70983c50f9
spec(normalized_address): add simple spec
2024-08-22 10:37:31 +02:00
mfo
fdff699d51
feat(champ.rnf/rna/siret): render normalized address the same way
2024-08-22 09:45:27 +02:00
Colin Darie
992c61b51a
fix: as of parsby 1.1, IO can be mutated during parsing
...
See 534f8a95b4/lib/parsby.rb (L572C11-L572C17)
Trace:
IOError: not modifiable string
# parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
# parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
# parsby-1.1.1/lib/parsby.rb:539:in `block in restore'
# parsby-1.1.1/lib/parsby.rb:539:in `each'
2024-08-22 09:26:48 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment
2024-08-22 09:26:48 +02:00
Lisa Durand
3cf3dc4623
make email confirmation more generic
2024-08-21 16:23:56 +02:00
Lisa Durand
ea354d46c4
Create new invitation email if expert not confirm
2024-08-21 16:19:51 +02:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
...
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable
2024-08-20 18:46:19 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one
2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
...
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
...
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
...
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
...
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json
2024-08-20 10:31:23 +02:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀
2024-08-19 15:46:14 +02:00
mfo
b910705353
move tdc facets builder to tdc
2024-08-19 15:30:08 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields
2024-08-19 15:30:08 +02:00
mfo
743ff8c8a9
extract Instructeurs::FacetTableHeaderComponent wrapping sort logic
2024-08-19 15:30:08 +02:00
simon lehericey
61051771a7
stay the old way for the moment ?
2024-08-19 15:30:07 +02:00
simon lehericey
ef63579e2e
clean facets_concern
2024-08-19 15:30:07 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select
2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options
2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets
2024-08-19 15:29:59 +02:00
simon lehericey
e19f1bd8c2
sortable? -> sorted_by
2024-08-19 15:29:59 +02:00