Commit graph

1935 commits

Author SHA1 Message Date
gregoirenovel
01f894316c Rename _variables.scss to _constants.scss 2017-04-20 10:41:02 +02:00
gregoirenovel
47936c7be7 Merge pull request #96 from sgmap/scss-lint
Add SCSS linting
2017-04-20 10:39:33 +02:00
gregoirenovel
301f12618b Add scss-lint to .circleci/config.yml 2017-04-20 10:35:54 +02:00
gregoirenovel
525d23528d Add .scss-lint.yml 2017-04-20 10:35:54 +02:00
gregoirenovel
5937e2a35f Add the scss_lint gem 2017-04-20 10:35:54 +02:00
gregoirenovel
d8cc41140b Remove an unexpected blank line 2017-04-20 10:35:53 +02:00
gregoirenovel
5d4dcf8ec7 Don't use line blocks 2017-04-20 10:35:53 +02:00
gregoirenovel
c10c2fc31b Selectors must be written in lowercase with hyphens 2017-04-20 10:35:53 +02:00
gregoirenovel
73caee0ff3 Remove unused declarations 2017-04-20 10:05:59 +02:00
gregoirenovel
c32a2432c7 Don’t use vendor prefixes 2017-04-20 10:05:59 +02:00
gregoirenovel
e2bd606e49 Declarations must be terminated by a semicolon 2017-04-20 10:05:58 +02:00
gregoirenovel
0316bac137 Use double-quoted strings 2017-04-20 10:05:58 +02:00
gregoirenovel
11e5943989 Only one selector per line 2017-04-20 10:05:56 +02:00
gregoirenovel
5e1c99d642 Opening curly braces must be preceded by one single space 2017-04-19 17:05:57 +02:00
gregoirenovel
8cad7361cf An operator must be surrounded by single spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
0789cfd311 Colons must be followed by a single space 2017-04-19 17:05:57 +02:00
gregoirenovel
8906801d6c Comment literals must be followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4b575bd386 Commas are followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4f0de677ab Begin pseudo elements with double colons 2017-04-19 17:05:57 +02:00
gregoirenovel
4b39e76c8a Use extend only with placeholders 2017-04-19 17:05:57 +02:00
gregoirenovel
f3ec7f1d42 Indent with two spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
af7b611dd0 < 1 numbers must all have a leading zero 2017-04-19 17:05:57 +02:00
gregoirenovel
c9ff601b28 Hex colors must be written with uppercase letters 2017-04-19 17:05:57 +02:00
gregoirenovel
f519896e54 Hex colors must be 6 characters long 2017-04-19 17:05:57 +02:00
gregoirenovel
2cae8e751e Blocks must be separated by an empty line 2017-04-19 17:05:57 +02:00
gregoirenovel
0d5dd9d492 Remove empty rules 2017-04-19 17:05:57 +02:00
gregoirenovel
6a13e481fd Fix the declaration order 2017-04-19 17:05:57 +02:00
gregoirenovel
0ed13c9fe7 Remove duplicated properties 2017-04-19 17:05:56 +02:00
gregoirenovel
c5fc77b606 Change the comments style 2017-04-19 17:05:56 +02:00
gregoirenovel
bb02339183 Use border: none instead of border: 0 2017-04-19 17:05:56 +02:00
gregoirenovel
db331447e1 Use hex codes for colors 2017-04-19 17:05:55 +02:00
gregoirenovel
0f914ce77d Merge pull request #59 from sgmap/mandatory_attachment
Mandatory attachment
2017-04-19 17:05:23 +02:00
Simon Lehericey
ce4a23ec7f MandatoryAttachment: show * near mandatory attachment 2017-04-19 15:45:45 +02:00
Simon Lehericey
2b969ef575 MandatoryAttachment: group missing errors logic together
and show errors only if not draft
2017-04-19 15:45:45 +02:00
gregoirenovel
6c7ed9d04a Merge pull request #119 from sgmap/cleanup
Cleanup
2017-04-19 12:01:30 +02:00
gregoirenovel
b00eb914da Use case statements instead of if statements where appropriated 2017-04-19 11:57:49 +02:00
gregoirenovel
9071656b55 Use #each instead of #map where appropriated 2017-04-19 11:57:49 +02:00
LeSim
a309f07771 Merge pull request #120 from sgmap/typography-fixes
Typography fixes
2017-04-19 11:56:34 +02:00
gregoirenovel
ddf02ccd6d Use a non-breaking space after the “numéro” contraction 2017-04-19 11:19:53 +02:00
gregoirenovel
aa41349f0c Lowercase the “n” of “numéro” contraction where needed 2017-04-19 11:19:53 +02:00
gregoirenovel
ba4ee68019 Use masculine ordinal indicator instead of the degree sign
It’s the right way to contract “numéro”

We should use the superscript lowercase o but
it’s hard to do in places where only raw text is
available
2017-04-19 11:19:53 +02:00
LeSim
42866fdcde Merge pull request #116 from sgmap/description_controller_refactor
Description controller refactor
2017-04-19 10:57:03 +02:00
Simon Lehericey
4cd21580fb DescriptionController: move html_safe to the view
html_safe could not work upon redirection as stated here :
https://groups.google.com/forum/#!topic/rubyonrails-core/z52zgDgUmbs
2017-04-19 10:52:04 +02:00
Simon Lehericey
eb3bb63a8f DescriptionController: remove useless @champs 2017-04-19 10:52:04 +02:00
Simon Lehericey
866a54085c DescriptionController: cosmetic 2017-04-19 10:52:04 +02:00
Simon Lehericey
157d1818b2 DescriptionController: move instance var to local var 2017-04-19 10:52:04 +02:00
gregoirenovel
b36252b916 Merge pull request #117 from sgmap/pieces_justificatives_improvements
Pieces justificatives improvements
2017-04-19 10:30:40 +02:00
Simon Lehericey
71542f6a3a PiecesJustificativesService: more explicit selection of content 2017-04-19 10:24:08 +02:00
Simon Lehericey
21d7a96062 PiecesJustificativesService: less violent error message in case of virus 2017-04-19 10:22:30 +02:00
Simon Lehericey
395c9d5bb1 PiecesJustificativesService: improve error message when the file cannot be saved 2017-04-19 10:20:32 +02:00