Commit graph

4150 commits

Author SHA1 Message Date
Paul Chavard
c417614695
fix(dossier): fix apply_diff with multiple changed rows 2024-10-16 14:15:26 +02:00
Mathieu Magnin
04bbf09097
Merge pull request #10939 from demarches-simplifiees/fix-10919
Correction bug champ carto
2024-10-15 18:13:13 +00:00
simon lehericey
5621edcca8
remove unused filtered? method 2024-10-15 16:09:09 +02:00
simon lehericey
f850924dc0
remove procedure_presentation from export 2024-10-15 16:09:09 +02:00
simon lehericey
71bcbbc440
remove useless snapshot 2024-10-15 16:09:09 +02:00
simon lehericey
b5ed8c9b61
export cache_key based on column 2024-10-15 16:09:08 +02:00
simon lehericey
954d232a47
add filtered and sorted columns to export 2024-10-15 16:09:08 +02:00
simon lehericey
603c2a108e
remove useless Export.by_key procedure_presentation arg 2024-10-15 16:09:08 +02:00
simon lehericey
d1530b40a1
use the filter_service 2024-10-15 16:09:08 +02:00
simon lehericey
4d7715fbb6
extract filter and sort function to a filter_service 2024-10-15 16:09:08 +02:00
simon lehericey
16e93a217b
reset procedure_presentation if a pb occurs with a column deserialization 2024-10-15 16:09:07 +02:00
mfo
112d49cb51
tech(deadcode): remove unused constant on ProcedurePresentation 2024-10-15 16:09:07 +02:00
simon lehericey
e41326dad5
tech(clean): remove sva_columns(for_filters)
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
3677f3b2d3
tech(clean): remove Column classname: attribute
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
30fcb75da4
extract dossier_state_column 2024-10-15 16:09:07 +02:00
simon lehericey
14483270ba
default default_displayed_column 2024-10-15 16:09:06 +02:00
simon lehericey
0a54db6db5
remove human_to_filter 2024-10-15 16:09:06 +02:00
simon lehericey
b2754cd26c
move validations concern to filtered_column
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:06 +02:00
simon lehericey
6b5efbda07
remove now unused code 2024-10-15 16:09:06 +02:00
simon lehericey
14fe11b612
use displayed_columns ! 2024-10-15 16:09:06 +02:00
simon lehericey
7e4ca07df2
use filtered_column to filter !
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:05 +02:00
simon lehericey
4c5d7e2950
remove now useless add_filters and remove_filters 2024-10-15 16:09:05 +02:00
simon lehericey
175f303399
display filter tags 2024-10-15 16:09:05 +02:00
simon lehericey
d54ab64e40
add filtered_column type 2024-10-15 16:09:05 +02:00
simon lehericey
4e0d3c2df1
improve Column not found error message 2024-10-15 15:48:41 +02:00
Mathieu Magnin
097074fdc7
Merge pull request #10865 from demarches-simplifiees/fix-10799
ETQ Admin / Instructeur je veux être savoir si le jeton api entreprise d'une démarche a expiré ou va expirer prochainement
2024-10-15 13:25:20 +00:00
Paul Chavard
d13c475170
fix(api_entreprise): better handle api entreprise errors 2024-10-15 15:24:37 +02:00
Benoit Queyron
c8f69283cc
Merge pull request #10713 from demarches-simplifiees/etq-admin-bug-message-info-character-limit
Tech : amélioration de la gestion des types_de_champ.options
2024-10-15 13:02:33 +00:00
Paul Chavard
8ddec687e6
Merge pull request #10873 from tchak/refactor-repetition-remove-parent_id
ETQ dev, je ne veux plus avoir de relation entre les champs et leur parent
2024-10-15 13:00:52 +00:00
Mathieu Magnin
029a75404d
[#10799] Fixes after @E-L-T review's 2024-10-15 14:40:51 +02:00
Mathieu Magnin
c897893e8a
[#10799] Remove dead code 2024-10-15 14:40:50 +02:00
Mathieu Magnin
e172f3ed6c
[#10799] Fix tests 2024-10-15 14:40:50 +02:00
Mathieu Magnin
6b326b634e
[#10799] Modifications after Marlene's comments 2024-10-15 14:40:50 +02:00
Mathieu Magnin
64297f9ee8
[#10799] Add error on procedure#show if api entreprise token is expiring 2024-10-15 14:40:50 +02:00
Mathieu Magnin
99a1b68185
[#10799] reorder methods A->Z 2024-10-15 14:40:49 +02:00
Mathieu Magnin
ec2c913ab4
[#10799] Display token error on related card 2024-10-15 14:40:49 +02:00
Mathieu Magnin
703a722c54
[#10799] Handle the case when api_entreprise_token is not nil then set to nil 2024-10-15 14:40:49 +02:00
Mathieu Magnin
7009eed9d7
[#10799] Move api entreprise token logic in a concern 2024-10-15 14:40:49 +02:00
Mathieu Magnin
2d9854dc01
[#10799] Declare api_entreprise_token_expires_at attribute and feed it on save 2024-10-15 14:40:49 +02:00
benoitqueyron
e88d84cf57
ajout d'un nettoyage des options des types_de_champ lors de la publication d'une procedure ou d'une nouvelle revision 2024-10-15 14:40:33 +02:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil 2024-10-15 14:40:33 +02:00
benoitqueyron
3c5749e45a
TypeDeChamp: purge notice explicative lors d'un changement de type_champ 2024-10-15 14:40:33 +02:00
simon lehericey
b588b77571
TypeDeChamp: amélioration de la gestion des drop_down_options 2024-10-15 14:40:15 +02:00
Mathieu Magnin
49c9f274e4
[#10919] When data in geo_area is invalid do not crash when .label is called 2024-10-15 14:37:32 +02:00
Paul Chavard
bd32f5693d
refactor(repetition): remove parent_id 2024-10-15 11:42:36 +02:00
Christophe Robillard
47a4f40939
destroy export_templates when destroy groupe_instructeur 2024-10-15 11:18:58 +02:00
Colin Darie
1c32a30b80
fix(filters): drop down list filters can have much longer values.
Notre infra supporte des urls d'au moins 8000 caractères, probablement
plus encore, donc on est large.
2024-10-14 16:01:48 +02:00
Kara Diaby
f025e08336
Ajoute la table procedure tags et la liaison entre procedure et procedures tags 2024-10-14 10:26:46 +02:00
Paul Chavard
960385831e
Merge pull request #10904 from tchak/remove-some-complex-champs-from-prefill
chore(prefill): remove unused prefill support on complex champs
2024-10-14 08:11:30 +00:00
Paul Chavard
f0d334ea69
Merge pull request #10916 from tchak/graphql-fix-n+1
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 15:20:53 +00:00
Paul Chavard
a3375be7c5
fix(graphql): n+1 on procedure and france_connect_informations 2024-10-11 12:20:24 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates 2024-10-11 11:20:46 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs 2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface 2024-10-09 09:23:06 +02:00
simon lehericey
14809b35af
add comments 2024-10-09 09:21:44 +02:00
simon lehericey
450420aa81
cache columns per request using Current 2024-10-08 22:51:26 +02:00
simon lehericey
249ddf291f
update_displayed_fields can use sorted_column 2024-10-08 22:51:26 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier 2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation 2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:) 2024-10-08 22:51:25 +02:00
simon lehericey
76fee12653
remove now unused procedure_presentation.opposite_order_for 2024-10-08 22:51:25 +02:00
simon lehericey
7349dd183a
notified_toggle_component use sorted_column 2024-10-08 22:51:24 +02:00
simon lehericey
22cbf725ec
column_table_header compute update_sort_path 2024-10-08 22:51:24 +02:00
simon lehericey
21533f91e3
add storted_column_type 2024-10-08 22:47:37 +02:00
simon lehericey
9652cf78c3
add default_sorted_column 2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column 2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type 2024-10-08 22:47:36 +02:00
mfo
5cba847d10
perf(Instructeurs/Dossiers#demande): remove n+1 2024-10-08 14:47:34 +02:00
simon lehericey
d5a722c143
weird frozen_string bug 2024-10-07 22:09:21 +02:00
simon lehericey
a418cf6632
remove_filter double_write 2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write 2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write 2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write 2024-10-07 22:09:20 +02:00
simon lehericey
0abee08329
add filters for 2024-10-07 22:09:20 +02:00
simon lehericey
3d79c6176e
add columns_ids to procedure_presentations table 2024-10-07 22:09:20 +02:00
simon lehericey
e3697bd976
colonne.id = { procedure_id:, column_id: }.to_json
because:
- id should be a string as other id
- id need procedure_id to allow ColumnType.deserialize(id) -> Column as the columns are built by a procedure
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id 2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id 2024-10-07 21:46:59 +02:00
simon lehericey
3c7521a428
extract dossier_id_column, notifications_column 2024-10-07 15:49:58 +02:00
simon lehericey
c6559577f1
remove old comment 2024-10-07 14:50:35 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at 2024-10-05 22:22:04 +02:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
ecbf985147
refactor(dossier): champs_* -> project_champs_* 2024-10-04 12:05:55 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic 2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent 2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
simon lehericey
fb66434a15
remove empty option at the start of default options 2024-09-30 15:37:02 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text 2024-09-30 15:37:02 +02:00
simon lehericey
5fc0eb11f5
rename remaining drop_down_list_enabled_non_empty_options(other: true) -> drop_down_options_with_other 2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible 2024-09-30 15:37:02 +02:00
simon lehericey
cfb03fc747
remove enabled_non_empty_options indirection 2024-09-30 15:37:01 +02:00
simon lehericey
77b754a08d
no more empty case 2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader 2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods 2024-09-27 11:34:06 +02:00
mfo
75063ae31e
fix(filter): filtering types_de_champs by enum should not ilike. nows it search by exact match since enum are normalized so findable with simple where 2024-09-24 20:48:10 +02:00
mfo
b30cbf3032
tech(doc): explain which columns are ilikable for user/individual 2024-09-24 20:48:09 +02:00
mfo
51ce0cd562
clean(filter): avis column are not filterable, not needed to ilike them 2024-09-24 20:47:43 +02:00
mfo
284bdc5b2b
clean(deadcode): their is no column for avis.label. so clean this one 2024-09-24 20:47:09 +02:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
closes #9825
2024-09-24 11:28:17 +02:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
mfo
12ef66c2b0
Merge pull request #10847 from mfo/US/clean-db
amélioration : ETQ tech je souhatie que ma base de donnée ne stock pas de donnée inutile
2024-09-24 08:12:09 +00:00
mfo
a71e83dabe
clean(db): remove ignored column 2024-09-24 10:04:04 +02:00
Paul Chavard
b5eb87de6a
fix(champ): improve row_id validation and remove it during export 2024-09-23 17:06:33 +02:00
mfo
7adbdaa4de
tech(clean): unused index and column 2024-09-23 14:53:37 +02:00
Paul Chavard
4ab9ef1f3f
Merge pull request #10842 from tchak/revert-du-revert-de-refactoring-champs
Revert "Revert "Merge pull request #10771""
2024-09-23 12:27:04 +00:00
Lisa Durand
0272f79c6a
migration to remove hidden_at from dossiers 2024-09-23 10:58:36 +02:00
Paul Chavard
3429a72f53
fix(dossier): do not show repetitions in header sections summary 2024-09-23 10:51:38 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
This reverts commit 10a1ae5534.
2024-09-23 10:21:07 +02:00
Paul Chavard
e4ac781b54
fix(rnf): remove deprecated status attribute 2024-09-20 16:58:51 +02:00
Mathieu Magnin
e9b5c4a615
[#10837] Add an explicit message when SIRET is not valid on service 2024-09-20 15:44:46 +02:00
mfo
cd8c55b161
Merge pull request #10814 from demarches-simplifiees/fix-10813
[bug] Ne pas afficher de 500 quand value_json d'un champ SIRET est nil
2024-09-19 15:22:45 +00:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
This reverts commit c902061ebf, reversing
changes made to b4ed11c788.
2024-09-19 11:09:01 +02:00
LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
Lisa Durand
3d50f9363f
Merge pull request #10741 from demarches-simplifiees/secu-improve-complexity-password-ldu
[sécu] Améliorer la complexité des mots de passe pour tous les users
2024-09-18 12:40:17 +00:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list 2024-09-18 10:26:00 +02:00
simon lehericey
51e192939c
pack drop_down stuff together 2024-09-18 10:08:12 +02:00
simon lehericey
85684e3bea
homogenize render? if not options 2024-09-18 10:08:12 +02:00
simon lehericey
f1a606da6d
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value 2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options 2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[#10813] When value_json of champ SIRET is nil do not crash 2024-09-17 19:05:36 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number 2024-09-17 15:18:23 +02:00
Paul Chavard
3fef831524
move child? method for clarity 2024-09-17 10:29:34 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids 2024-09-17 10:29:34 +02:00
Paul Chavard
33e502234e
refactor(dossier loader): simplify all the things 2024-09-17 10:29:34 +02:00
Paul Chavard
2ba356bc68
cleanup(prefill): remove unused validation 2024-09-17 10:29:34 +02:00
Paul Chavard
c94d1b7eea
cleanup: more concistent methods usage 2024-09-17 10:29:34 +02:00
Paul Chavard
a474cf4590
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ 2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage 2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision 2024-09-17 10:29:34 +02:00
Paul Chavard
ed4fbc887a
refactor(dossier): remove unused scopes 2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods 2024-09-17 10:29:34 +02:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content 2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Lisa Durand
00a155b896
add password complexity for instructeur, user and password change 2024-09-16 15:23:43 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db 2024-09-16 12:55:59 +02:00
mfo
7a78fdc913
fix(normalized_address): should not raise an error for addresses without code postal 2024-09-13 11:19:05 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
This reverts commit 4289aa2cf5.
2024-09-13 11:00:08 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Mathieu Magnin
a99fae168c
[#10751] Allow sending a new invitation if the user's previous one has expired 2024-09-11 18:45:15 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range 2024-09-10 17:47:50 +02:00
Colin Darie
6240d54fd4
fix: unbreakable space for better look in filters 2024-09-10 12:36:13 +02:00