From f6366a9cd3a8dbc2734b878fcf7dbd6bf14c12c9 Mon Sep 17 00:00:00 2001 From: Colin Darie Date: Tue, 10 Dec 2024 15:52:17 +0100 Subject: [PATCH] refactor(dossier): predicates methods must return boolean --- app/models/concerns/dossier_clone_concern.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/concerns/dossier_clone_concern.rb b/app/models/concerns/dossier_clone_concern.rb index e147c9a20..84b9ed481 100644 --- a/app/models/concerns/dossier_clone_concern.rb +++ b/app/models/concerns/dossier_clone_concern.rb @@ -38,15 +38,15 @@ module DossierCloneConcern end def forked_with_changes? - if forked_diff.present? - forked_diff.values.any?(&:present?) || forked_groupe_instructeur_changed? - end + return false if forked_diff.blank? + + forked_diff.values.any?(&:present?) || forked_groupe_instructeur_changed? end def champ_forked_with_changes?(champ) - if forked_diff.present? - forked_diff.values.any? { |champs| champs.any? { _1.public_id == champ.public_id } } - end + return false if forked_diff.blank? + + forked_diff.values.any? { |champs| champs.any? { _1.public_id == champ.public_id } } end def make_diff(editing_fork)