DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #8723 from colinux/fix-failing-jobs

Browse source 
Attempts to fix timeout and errors cron jobs
This commit is contained in:
Colin Darie 2023-03-06 14:02:55 +00:00 • committed by GitHub
commit d87495c5fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 47 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec/jobs/cron/weekly_overview_job_spec.rb
View file

@ -2,7 +2,6 @@ RSpec.describe Cron::WeeklyOverviewJob, type: :job do
describe 'perform' do
let!(:instructeur) { create(:instructeur) }
let(:overview) { double('overview') }
let(:mailer_double) { double('mailer', deliver_later: true) }
context 'if the feature is enabled' do
before do
@ -12,11 +11,14 @@ RSpec.describe Cron::WeeklyOverviewJob, type: :job do
Rails.application.config.ds_weekly_overview = false
end
subject(:run_job) { Cron::WeeklyOverviewJob.new.perform }
# See also spec/mailers/instructeur_mailer_spec.rb
context 'with one instructeur with one overview' do
let(:mailer_double) { double('mailer', deliver_later: true) }
before do
expect_any_instance_of(Instructeur).to receive(:last_week_overview).and_return(overview)
allow(InstructeurMailer).to receive(:last_week_overview).and_return(mailer_double)
Cron::WeeklyOverviewJob.new.perform
run_job
end
it { expect(InstructeurMailer).to have_received(:last_week_overview).with(instructeur) }
@ -25,22 +27,22 @@ RSpec.describe Cron::WeeklyOverviewJob, type: :job do
context 'with one instructeur with no overviews' do
before do
expect_any_instance_of(Instructeur).to receive(:last_week_overview).and_return(nil)
allow(InstructeurMailer).to receive(:last_week_overview)
Cron::WeeklyOverviewJob.new.perform
allow(InstructeurMailer).to receive(:last_week_overview).and_return(nil)
run_job
end
it { expect(InstructeurMailer).not_to have_received(:last_week_overview) }
it { expect(InstructeurMailer).to have_received(:last_week_overview).with(instructeur) }
it { expect { run_job }.not_to raise_error(NoMethodError) }
end
end
context 'if the feature is disabled' do
before do
allow(Instructeur).to receive(:all)
allow(Instructeur).to receive(:find_each)
Cron::WeeklyOverviewJob.new.perform
end
it { expect(Instructeur).not_to receive(:all) }
it { expect(Instructeur).not_to receive(:find_each) }
end
end
end