diff --git a/app/assets/images/instructions_moncomptepro.png b/app/assets/images/instructions_moncomptepro.png new file mode 100644 index 000000000..554d388b5 Binary files /dev/null and b/app/assets/images/instructions_moncomptepro.png differ diff --git a/app/controllers/agent_connect/agent_controller.rb b/app/controllers/agent_connect/agent_controller.rb index ee7e8d7be..0ecefb767 100644 --- a/app/controllers/agent_connect/agent_controller.rb +++ b/app/controllers/agent_connect/agent_controller.rb @@ -10,6 +10,9 @@ class AgentConnect::AgentController < ApplicationController STATE_COOKIE_NAME = :agentConnect_state NONCE_COOKIE_NAME = :agentConnect_nonce + AC_ID_TOKEN_COOKIE_NAME = :agentConnect_id_token + REDIRECT_TO_AC_LOGIN_COOKIE_NAME = :redirect_to_ac_login + def index end @@ -27,7 +30,11 @@ class AgentConnect::AgentController < ApplicationController cookies.delete NONCE_COOKIE_NAME if user_info['idp_id'] == MON_COMPTE_PRO_IDP_ID && !amr.include?('mfa') - return redirect_to ENV['MON_COMPTE_PRO_2FA_NOT_CONFIGURED_URL'], allow_other_host: true + # we need the id_token to disconnect the agent connect session later. + # we cannot store it in the instructeur model because the user is not yet created + # so we store it in a encrypted cookie + cookies.encrypted[AC_ID_TOKEN_COOKIE_NAME] = id_token + return redirect_to agent_connect_explanation_2fa_path end instructeur = Instructeur.find_by(users: { email: santized_email(user_info) }) @@ -52,6 +59,31 @@ class AgentConnect::AgentController < ApplicationController redirect_france_connect_error_connection end + def explanation_2fa + end + + # Special callback from MonComptePro juste after 2FA configuration + # then: + # - the current user is disconnected from the AgentConnect session by redirecting to the AgentConnect logout endpoint + # - the user is redirected to User::SessionsController#logout by agent connect (no choice) + # - the cookie redirect_to_ac_login is detected and the controller redirects to the relogin_after_2fa_config page + # - finally, the user clicks on the button to reconnect to the AgentConnect session + def logout_from_mcp + sign_out(:user) if user_signed_in? + + id_token = cookies.encrypted[AC_ID_TOKEN_COOKIE_NAME] + cookies.delete(AC_ID_TOKEN_COOKIE_NAME) + + return redirect_to root_path if id_token.blank? + + cookies.encrypted[REDIRECT_TO_AC_LOGIN_COOKIE_NAME] = true + + redirect_to AgentConnectService.logout_url(id_token, host_with_port: request.host_with_port), allow_other_host: true + end + + def relogin_after_2fa_config + end + private def santized_email(user_info) diff --git a/app/controllers/users/sessions_controller.rb b/app/controllers/users/sessions_controller.rb index 601f533dc..7b764fbff 100644 --- a/app/controllers/users/sessions_controller.rb +++ b/app/controllers/users/sessions_controller.rb @@ -109,6 +109,12 @@ class Users::SessionsController < Devise::SessionsController # agent connect callback def logout + if cookies.encrypted[AgentConnect::AgentController::REDIRECT_TO_AC_LOGIN_COOKIE_NAME].present? + cookies.delete(AgentConnect::AgentController::REDIRECT_TO_AC_LOGIN_COOKIE_NAME) + + return redirect_to agent_connect_relogin_after_2fa_config_path + end + redirect_to root_path, notice: I18n.t('devise.sessions.signed_out') end end diff --git a/app/views/agent_connect/agent/explanation_2fa.html.haml b/app/views/agent_connect/agent/explanation_2fa.html.haml new file mode 100644 index 000000000..ab52b99f1 --- /dev/null +++ b/app/views/agent_connect/agent/explanation_2fa.html.haml @@ -0,0 +1,14 @@ +.fr-container + %h1.fr-h2.fr-mt-4w Une validation en 2 étapes est désormais nécessaire. + + %p.fr-mb-2w + La sécurité de votre compte augmente. Nous vous demandons à présent une validation en 2 étapes pour vous connecter. + + %p.fr-mb-2w + Vous allez devoir configurer votre mode d'authentification sur le site MonComptePro : + + %img{ src: image_url("instructions_moncomptepro.png"), alt: "MonComptePro", loading: 'lazy' } + + + %button.fr-btn.fr-btn--primary.fr-mb-2w + = link_to "Configurer mon appli d'authentification sur MonComptePro", ENV['MON_COMPTE_PRO_2FA_NOT_CONFIGURED_URL'] diff --git a/app/views/agent_connect/agent/relogin_after_2fa_config.html.haml b/app/views/agent_connect/agent/relogin_after_2fa_config.html.haml new file mode 100644 index 000000000..898f57497 --- /dev/null +++ b/app/views/agent_connect/agent/relogin_after_2fa_config.html.haml @@ -0,0 +1,12 @@ +.fr-container + %h1.fr-h2.fr-mt-4w Poursuivez votre connexion à #{APPLICATION_NAME} + + = render Dsfr::AlertComponent.new(state: :success, extra_class_names: 'fr-mb-4w') do |c| + - c.with_body do + %p Votre application d'authentification a bien été configurée. + + %p.fr-mb-4w + Vous allez maintenant pouvoir vous connecter à nouveau à #{APPLICATION_NAME} en effectuant la validation en 2 étapes avec votre application d'authentification. + + %button.fr-btn.fr-btn--primary.fr-mb-2w + = link_to "Se connecter à #{APPLICATION_NAME} avec #{AgentConnect}", agent_connect_login_path diff --git a/config/routes.rb b/config/routes.rb index 57031dc7c..86b1ef45a 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -202,6 +202,9 @@ Rails.application.routes.draw do get '' => 'agent#index' get 'login' => 'agent#login' get 'callback' => 'agent#callback' + get 'explanation_2fa' => 'agent#explanation_2fa' + get 'relogin_after_2fa_config' => 'agent#relogin_after_2fa_config' + get 'logout_from_mcp' => 'agent#logout_from_mcp' end namespace :champs do diff --git a/spec/controllers/agent_connect/agent_controller_spec.rb b/spec/controllers/agent_connect/agent_controller_spec.rb index cebed5946..9c55a82c3 100644 --- a/spec/controllers/agent_connect/agent_controller_spec.rb +++ b/spec/controllers/agent_connect/agent_controller_spec.rb @@ -38,24 +38,24 @@ describe AgentConnect::AgentController, type: :controller do context 'and user_info returns some info' do before do - ENV['MON_COMPTE_PRO_2FA_NOT_CONFIGURED_URL'] = 'https://moncomptepro.fr/not_configured' expect(AgentConnectService).to receive(:user_info).with(code, nonce).and_return([user_info, id_token, amr]) end - context 'and the instructeur use mon_compte_pro without 2FA' do + context 'and the instructeur use mon_compte_pro' do before do user_info['idp_id'] = AgentConnect::AgentController::MON_COMPTE_PRO_IDP_ID allow(controller).to receive(:sign_in) end context 'without 2FA' do - it 'redirects to MON_COMPTE_PRO_2FA_NOT_CONFIGURED_URL' do + it 'redirects to agent_connect_explanation_2fa_path' do subject expect(controller).not_to have_received(:sign_in) - expect(response).to redirect_to(ENV['MON_COMPTE_PRO_2FA_NOT_CONFIGURED_URL']) + expect(response).to redirect_to(agent_connect_explanation_2fa_path) expect(state_cookie).to be_nil expect(nonce_cookie).to be_nil + expect(cookies.encrypted[controller.class::AC_ID_TOKEN_COOKIE_NAME]).to eq(id_token) end end @@ -198,6 +198,37 @@ describe AgentConnect::AgentController, type: :controller do end end + describe '#logout_from_mcp' do + let(:id_token) { 'id_token' } + subject { get :logout_from_mcp } + + before do + cookies.encrypted[controller.class::AC_ID_TOKEN_COOKIE_NAME] = id_token + end + + it 'clears the id token cookie and redirects to the agent connect logout url' do + expect(AgentConnectService).to receive(:logout_url).with(id_token, host_with_port: 'test.host') + .and_return("https://agent-connect.fr/logout/#{id_token}") + + subject + + expect(cookies.encrypted[controller.class::AC_ID_TOKEN_COOKIE_NAME]).to be_nil + expect(cookies.encrypted[controller.class::REDIRECT_TO_AC_LOGIN_COOKIE_NAME]).to eq(true) + expect(response).to redirect_to("https://agent-connect.fr/logout/#{id_token}") + end + + context 'when the id_token is blank' do + let(:id_token) { nil } + + it 'clears the cookies and redirects to the root path' do + subject + + expect(cookies.encrypted[controller.class::REDIRECT_TO_AC_LOGIN_COOKIE_NAME]).to be_nil + expect(response).to redirect_to(root_path) + end + end + end + def state_cookie cookies.encrypted[controller.class::STATE_COOKIE_NAME] end diff --git a/spec/controllers/users/sessions_controller_spec.rb b/spec/controllers/users/sessions_controller_spec.rb index e4fde9b2f..42c4e0f58 100644 --- a/spec/controllers/users/sessions_controller_spec.rb +++ b/spec/controllers/users/sessions_controller_spec.rb @@ -311,4 +311,21 @@ describe Users::SessionsController, type: :controller do end end end + + describe '#logout' do + subject { get :logout } + + it 'redirects to root_path' do + expect(subject).to redirect_to(root_path) + end + + context 'when the cookie redirect_to_ac_login is present' do + before { cookies.encrypted[AgentConnect::AgentController::REDIRECT_TO_AC_LOGIN_COOKIE_NAME] = true } + + it 'redirects to relogin_after_2fa_config' do + expect(subject).to redirect_to(agent_connect_relogin_after_2fa_config_path) + expect(cookies.encrypted[AgentConnect::AgentController::REDIRECT_TO_AC_LOGIN_COOKIE_NAME]).to be_nil + end + end + end end