From c81adb80fd8e290cea56e2042452d5e7783a2599 Mon Sep 17 00:00:00 2001
From: Frederic Merizen <frederic.merizen@beta.gouv.fr>
Date: Tue, 19 Feb 2019 15:42:58 +0100
Subject: [PATCH] [#3477] Better choice of case vs if

---
 .../new_gestionnaire/procedures_controller.rb          | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/controllers/new_gestionnaire/procedures_controller.rb b/app/controllers/new_gestionnaire/procedures_controller.rb
index cec7571f3..84ea6f9cd 100644
--- a/app/controllers/new_gestionnaire/procedures_controller.rb
+++ b/app/controllers/new_gestionnaire/procedures_controller.rb
@@ -245,14 +245,16 @@ module NewGestionnaire
       procedure_presentation.displayed_fields
         .reject { |field| field['table'] == 'self' }
         .group_by do |field|
-          if ['type_de_champ', 'type_de_champ_private'].include?(field['table'])
+          case field['table']
+          when 'type_de_champ', 'type_de_champ_private'
             'type_de_champ_group'
           else
             field['table']
           end
         end.reduce(dossiers) do |dossiers, (group_key, fields)|
-          case group_key
-          when 'type_de_champ_group'
+          if group_key != 'type_de_champ_group'
+            dossiers.includes(fields.first['table'])
+          else
             if fields.any? { |field| field['table'] == 'type_de_champ' }
               dossiers = dossiers.includes(:champs).references(:champs)
             end
@@ -266,8 +268,6 @@ module NewGestionnaire
             end.join(" OR ")
 
             dossiers.where(where_conditions)
-          else
-            dossiers.includes(fields.first['table'])
           end
         end
     end