DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #4233 from betagouv/fix-3536-remove-sign_up-from-sign_in

Browse source 
Fix 3536 Suppression de la possibilité de se créer un compte depuis la home
This commit is contained in:
LeSim 2019-08-27 10:50:51 +02:00 committed by GitHub
commit ab75d5b7e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/views/users/sessions/new.html.haml
View file

@ -1,12 +1,6 @@
= content_for(:page_id, 'auth') = content_for(:page_id, 'auth')
.auth-form.sign-in-form .auth-form.sign-in-form
%p.register
%span
Nouveau sur demarches‑simplifiees.fr ?
= link_to "Créer un compte", new_user_registration_path, class: "button primary auth-signup-button"
%hr
= form_for User.new, url: user_session_path, html: { class: "form" } do |f| = form_for User.new, url: user_session_path, html: { class: "form" } do |f|
%h1 Connectez-vous %h1 Connectez-vous
@ -28,3 +22,10 @@
= f.submit "Se connecter", class: "button large primary expand" = f.submit "Se connecter", class: "button large primary expand"
= render partial: 'shared/france_connect_login', locals: { url: france_connect_particulier_path } = render partial: 'shared/france_connect_login', locals: { url: france_connect_particulier_path }
%hr
%p.center
%span Vous êtes nouveau sur demarches‑simplifiees.fr ?
%br
%br
= link_to "Trouvez votre démarche", "https://faq.demarches-simplifiees.fr/article/59-comment-trouver-ma-demarche", target: "_blank", class: "button expend secondary"

20
spec/features/users/sign_up_spec.rb
View file

@ -3,24 +3,23 @@ require 'spec_helper'
feature 'Signing up:' do feature 'Signing up:' do
let(:user_email) { generate :user_email } let(:user_email) { generate :user_email }
let(:user_password) { 'démarches-simplifiées-pwd' } let(:user_password) { 'démarches-simplifiées-pwd' }
let(:procedure) { create :simple_procedure, :with_service }
scenario 'a new user can sign-up' do scenario 'a new user can sign-up' do
visit root_path visit commencer_path(path: procedure.path)
click_on 'Connexion' click_on 'Créer un compte demarches-simplifiees.fr'
click_on 'Créer un compte'
sign_up_with user_email, user_password sign_up_with user_email, user_password
expect(page).to have_content "nous avons besoin de vérifier votre adresse #{user_email}" expect(page).to have_content "nous avons besoin de vérifier votre adresse #{user_email}"
click_confirmation_link_for user_email click_confirmation_link_for user_email
expect(page).to have_content 'Votre compte a été activé' expect(page).to have_content 'Votre compte a été activé'
expect(page).to have_current_path dossiers_path expect(page).to have_current_path commencer_path(path: procedure.path)
end end
scenario 'a new user can’t sign-up with too short password' do scenario 'a new user can’t sign-up with too short password when visiting a procedure' do
visit root_path visit commencer_path(path: procedure.path)
click_on 'Connexion' click_on 'Créer un compte demarches-simplifiees.fr'
click_on 'Créer un compte'
expect(page).to have_current_path new_user_registration_path expect(page).to have_current_path new_user_registration_path
sign_up_with user_email, '1234567' sign_up_with user_email, '1234567'
@ -61,9 +60,8 @@ feature 'Signing up:' do
context 'when a user is not confirmed yet' do context 'when a user is not confirmed yet' do
before do before do
visit root_path visit commencer_path(path: procedure.path)
click_on 'Connexion' click_on 'Créer un compte demarches-simplifiees.fr'
click_on 'Créer un compte'
sign_up_with user_email, user_password sign_up_with user_email, user_password
end end