From 96b3547788ebed825cb1562a803fa5e3b8d3e471 Mon Sep 17 00:00:00 2001
From: Paul Chavard <git@paul.chavard.net>
Date: Fri, 3 May 2019 17:24:42 +0200
Subject: [PATCH] Exercices and RNA information are optional and should not
 block the request

---
 app/services/api_entreprise_service.rb       |  19 ++--
 spec/services/api_entreprise_service_spec.rb | 101 +++++++++++++++++++
 2 files changed, 113 insertions(+), 7 deletions(-)
 create mode 100644 spec/services/api_entreprise_service_spec.rb

diff --git a/app/services/api_entreprise_service.rb b/app/services/api_entreprise_service.rb
index 70751186d..feb687544 100644
--- a/app/services/api_entreprise_service.rb
+++ b/app/services/api_entreprise_service.rb
@@ -11,14 +11,19 @@ class ApiEntrepriseService
     entreprise_params = ApiEntreprise::EntrepriseAdapter.new(siret, procedure_id).to_params
 
     if etablissement_params.present? && entreprise_params.present?
-      association_params = ApiEntreprise::RNAAdapter.new(siret, procedure_id).to_params
-      exercices_params = ApiEntreprise::ExercicesAdapter.new(siret, procedure_id).to_params
+      begin
+        association_params = ApiEntreprise::RNAAdapter.new(siret, procedure_id).to_params
+        etablissement_params.merge!(association_params)
+      rescue RestClient::RequestFailed
+      end
 
-      etablissement_params.merge(
-        entreprise_params,
-        association_params,
-        exercices_params
-      )
+      begin
+        exercices_params = ApiEntreprise::ExercicesAdapter.new(siret, procedure_id).to_params
+        etablissement_params.merge!(exercices_params)
+      rescue RestClient::RequestFailed
+      end
+
+      etablissement_params.merge(entreprise_params)
     end
   end
 end
diff --git a/spec/services/api_entreprise_service_spec.rb b/spec/services/api_entreprise_service_spec.rb
new file mode 100644
index 000000000..0fefcb99e
--- /dev/null
+++ b/spec/services/api_entreprise_service_spec.rb
@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe ApiEntrepriseService do
+  describe '#get_etablissement_params_for_siret' do
+    before do
+      stub_request(:get, /https:\/\/entreprise.api.gouv.fr\/v2\/entreprises\/#{siren}?.*token=/)
+        .to_return(body: entreprises_body, status: entreprises_status)
+      stub_request(:get, /https:\/\/entreprise.api.gouv.fr\/v2\/etablissements\/#{siret}?.*token=/)
+        .to_return(body: etablissements_body, status: etablissements_status)
+      stub_request(:get, /https:\/\/entreprise.api.gouv.fr\/v2\/exercices\/.*token=/)
+        .to_return(body: exercices_body, status: exercices_status)
+      stub_request(:get, /https:\/\/entreprise.api.gouv.fr\/v2\/associations\/.*token=/)
+        .to_return(body: associations_body, status: associations_status)
+    end
+
+    let(:siren) { '418166096' }
+    let(:siret) { '41816609600051' }
+    let(:rna) { 'W595001988' }
+
+    let(:entreprises_status) { 200 }
+    let(:entreprises_body) { File.read('spec/fixtures/files/api_entreprise/entreprises.json') }
+
+    let(:etablissements_status) { 200 }
+    let(:etablissements_body) { File.read('spec/fixtures/files/api_entreprise/etablissements.json') }
+
+    let(:exercices_status) { 200 }
+    let(:exercices_body) { File.read('spec/fixtures/files/api_entreprise/exercices.json') }
+
+    let(:associations_status) { 200 }
+    let(:associations_body) { File.read('spec/fixtures/files/api_entreprise/associations.json') }
+
+    let(:result) { ApiEntrepriseService.get_etablissement_params_for_siret(siret, '1') }
+
+    context 'when service is up' do
+      it 'should fetch etablissement params' do
+        expect(result[:entreprise_siren]).to eq(siren)
+        expect(result[:siret]).to eq(siret)
+        expect(result[:association_rna]).to eq(rna)
+        expect(result[:exercices_attributes]).to_not be_empty
+      end
+    end
+
+    context 'when exercices api down' do
+      let(:exercices_status) { 400 }
+      let(:exercices_body) { '' }
+
+      it 'should fetch etablissement params' do
+        expect(result[:entreprise_siren]).to eq(siren)
+        expect(result[:siret]).to eq(siret)
+        expect(result[:exercices_attributes]).to be_nil
+      end
+    end
+
+    context 'when associations api down' do
+      let(:associations_status) { 400 }
+      let(:associations_body) { '' }
+
+      it 'should fetch etablissement params' do
+        expect(result[:entreprise_siren]).to eq(siren)
+        expect(result[:siret]).to eq(siret)
+        expect(result[:association_rna]).to be_nil
+      end
+    end
+
+    context 'when entreprise api down' do
+      let(:entreprises_status) { 400 }
+      let(:entreprises_body) { '' }
+
+      it 'should raise RestClient::RequestFailed' do
+        expect { result }.to raise_error(RestClient::RequestFailed)
+      end
+    end
+
+    context 'when etablissement api down' do
+      let(:etablissements_status) { 400 }
+      let(:etablissements_body) { '' }
+
+      it 'should raise RestClient::RequestFailed' do
+        expect { result }.to raise_error(RestClient::RequestFailed)
+      end
+    end
+
+    context 'when etablissement not found' do
+      let(:etablissements_status) { 404 }
+      let(:etablissements_body) { '' }
+
+      it 'should return nil' do
+        expect(result).to be_nil
+      end
+    end
+
+    context 'when entreprise not found' do
+      let(:etablissements_status) { 404 }
+      let(:etablissements_body) { '' }
+
+      it 'should return nil' do
+        expect(result).to be_nil
+      end
+    end
+  end
+end