diff --git a/app/controllers/api/v2/dossiers_controller.rb b/app/controllers/api/v2/dossiers_controller.rb index 16ae73c83..37f696b36 100644 --- a/app/controllers/api/v2/dossiers_controller.rb +++ b/app/controllers/api/v2/dossiers_controller.rb @@ -14,10 +14,10 @@ class API::V2::DossiersController < API::V2::BaseController private - def append_info_to_payload(payload) + def request_logs(logs) super if dossier.present? - payload.merge!(ds_dossier_id: dossier.id.to_s, ds_procedure_id: dossier.procedure.id.to_s) + logs.merge!(ds_dossier_id: dossier.id.to_s, ds_procedure_id: dossier.procedure.id.to_s) end end diff --git a/app/controllers/api/v2/graphql_controller.rb b/app/controllers/api/v2/graphql_controller.rb index e35798d20..c258613cf 100644 --- a/app/controllers/api/v2/graphql_controller.rb +++ b/app/controllers/api/v2/graphql_controller.rb @@ -18,10 +18,10 @@ class API::V2::GraphqlController < API::V2::BaseController private - def append_info_to_payload(payload) + def request_logs(logs) super - payload.merge!(@query_info.presence || {}) + logs.merge!(@query_info.presence || {}) end def process_action(*args) diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index bfc334d69..eb4dc8d81 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -224,23 +224,26 @@ class ApplicationController < ActionController::Base def append_info_to_payload(payload) super - payload.merge!({ + payload[:to_log] = {} + request_logs(payload[:to_log]) + end + + def request_logs(logs) + logs.merge!({ user_agent: request.user_agent, user_id: current_user&.id, user_roles: current_user_roles, client_ip: request.headers['X-Forwarded-For'], request_id: request.headers['X-Request-ID'] - }.compact) + }) if browser.known? - payload.merge!({ + logs.merge!({ browser: browser.name, browser_version: browser.version.to_s, platform: browser.platform.name }) end - - payload end def reject diff --git a/app/controllers/manager/application_controller.rb b/app/controllers/manager/application_controller.rb index 195f36d03..07a4f842e 100644 --- a/app/controllers/manager/application_controller.rb +++ b/app/controllers/manager/application_controller.rb @@ -38,21 +38,21 @@ module Manager def append_info_to_payload(payload) super - payload.merge!({ + to_log = { user_agent: request.user_agent, user_id: current_user&.id, user_email: current_user&.email - }.compact) + } if browser.known? - payload.merge!({ + to_log.merge!({ browser: browser.name, browser_version: browser.version.to_s, platform: browser.platform.name }) end - payload + payload[:to_log] = to_log end end end diff --git a/config/initializers/lograge.rb b/config/initializers/lograge.rb index b5795fde2..391938663 100644 --- a/config/initializers/lograge.rb +++ b/config/initializers/lograge.rb @@ -6,30 +6,18 @@ Rails.application.configure do # injected by ansible. if !config.lograge.custom_options config.lograge.custom_options = lambda do |event| - { + hash = { type: 'tps', source: ENV['SOURCE'], tags: ['request', event.payload[:exception] ? 'exception' : nil].compact, - user_id: event.payload[:user_id], - user_email: event.payload[:user_email], - user_roles: event.payload[:user_roles], - user_agent: event.payload[:user_agent], - graphql_query: event.payload[:graphql_query], - graphql_variables: event.payload[:graphql_variables], - graphql_null_error: event.payload[:graphql_null_error], - graphql_timeout_error: event.payload[:graphql_timeout_error], - graphql_mutation: event.payload[:graphql_mutation], - ds_procedure_id: event.payload[:ds_procedure_id], - ds_dossier_id: event.payload[:ds_dossier_id], - browser: event.payload[:browser], - browser_version: event.payload[:browser_version], - platform: event.payload[:platform], - client_ip: event.payload[:client_ip], - request_id: event.payload[:request_id], process: { pid: Process.pid } - }.compact + } + + hash.merge!(event.payload[:to_log]) + + hash.compact end config.lograge.custom_payload do |controller| diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb index 1c4b223db..5d30e90aa 100644 --- a/spec/controllers/application_controller_spec.rb +++ b/spec/controllers/application_controller_spec.rb @@ -40,7 +40,7 @@ describe ApplicationController, type: :controller do [:db_runtime, :view_runtime, :variant, :rendered_format].each do |key| payload.delete(key) end - expect(payload).to eq({ + expect(payload[:to_log].compact).to eq({ user_agent: 'Rails Testing', user_roles: 'Guest' }) @@ -59,7 +59,7 @@ describe ApplicationController, type: :controller do [:db_runtime, :view_runtime, :variant, :rendered_format].each do |key| payload.delete(key) end - expect(payload).to eq({ + expect(payload[:to_log].compact).to eq({ user_agent: 'Rails Testing', user_id: current_user.id, user_roles: 'User' @@ -82,7 +82,7 @@ describe ApplicationController, type: :controller do [:db_runtime, :view_runtime, :variant, :rendered_format].each do |key| payload.delete(key) end - expect(payload).to eq({ + expect(payload[:to_log].compact).to eq({ user_agent: 'Rails Testing', user_id: current_user.id, user_roles: 'User, Instructeur, Administrateur, SuperAdmin' diff --git a/spec/controllers/manager/application_controller_spec.rb b/spec/controllers/manager/application_controller_spec.rb index 7f8fab059..357f5d177 100644 --- a/spec/controllers/manager/application_controller_spec.rb +++ b/spec/controllers/manager/application_controller_spec.rb @@ -13,7 +13,7 @@ describe Manager::ApplicationController, type: :controller do [:db_runtime, :view_runtime, :variant, :rendered_format].each do |key| payload.delete(key) end - expect(payload).to eq({ + expect(payload[:to_log]).to eq({ user_agent: 'Rails Testing', user_id: current_user.id, user_email: current_user.email