From 8a5420301c2caa5ba0482ed9cd84b6fa6d4aa9b3 Mon Sep 17 00:00:00 2001
From: gregoirenovel <log@kinko.fr>
Date: Fri, 12 May 2017 13:32:48 +0200
Subject: [PATCH] Add Commentaire#notify to dispatch notifications

---
 app/models/commentaire.rb       | 32 +++++++++++++++-----
 spec/factories/invite_user.rb   | 24 +++++++++++++++
 spec/models/commentaire_spec.rb | 52 +++++++++++++++++++++++++++++++++
 3 files changed, 100 insertions(+), 8 deletions(-)
 create mode 100644 spec/factories/invite_user.rb

diff --git a/app/models/commentaire.rb b/app/models/commentaire.rb
index 1617e36c7..001976ab3 100644
--- a/app/models/commentaire.rb
+++ b/app/models/commentaire.rb
@@ -4,8 +4,7 @@ class Commentaire < ActiveRecord::Base
 
   belongs_to :piece_justificative
 
-  after_save :notify_gestionnaires
-  after_save :notify_user
+  after_create :notify
 
   def header
     "#{email}, " + I18n.l(created_at.localtime, format: '%d %b %Y %H:%M')
@@ -13,15 +12,32 @@ class Commentaire < ActiveRecord::Base
 
   private
 
-  def notify_gestionnaires
-    if email == dossier.user.email || dossier.invites_user.pluck(:email).to_a.include?(email)
-      NotificationService.new('commentaire', self.dossier.id).notify
+  def notify
+    dossier_user_email = dossier.user.email
+    invited_users_emails = dossier.invites_user.pluck(:email).to_a
+
+    case email
+    when "contact@tps.apientreprise.fr"
+      # The commentaire is a copy of an automated notification email
+      # we sent to a user, so do nothing
+    when dossier_user_email, *invited_users_emails
+      # A user or an inved user posted a commentaire,
+      # we need to notify the gestionnaires
+
+      notify_gestionnaires
+    else
+      # A gestionnaire posted a commentaire,
+      # we need to notify the user
+
+      notify_user
     end
   end
 
+  def notify_gestionnaires
+    NotificationService.new('commentaire', self.dossier.id).notify
+  end
+
   def notify_user
-    if email != dossier.user.email && email != 'contact@tps.apientreprise.fr'
-      NotificationMailer.new_answer(dossier).deliver_now!
-    end
+    NotificationMailer.new_answer(dossier).deliver_now!
   end
 end
diff --git a/spec/factories/invite_user.rb b/spec/factories/invite_user.rb
new file mode 100644
index 000000000..c4f7dcdbd
--- /dev/null
+++ b/spec/factories/invite_user.rb
@@ -0,0 +1,24 @@
+FactoryGirl.define do
+  factory :invite_user do
+    email 'plop@octo.com'
+
+    after(:build) do |invite, _evaluator|
+      if invite.dossier.nil?
+        invite.dossier = create(:dossier)
+      end
+
+      unless invite.user.nil?
+        invite.email = invite.user.email
+      end
+    end
+
+    trait :with_user do
+      after(:build) do |invite, _evaluator|
+        if invite.user.nil?
+          invite.user = create(:user)
+          invite.email = invite.user.email
+        end
+      end
+    end
+  end
+end
diff --git a/spec/models/commentaire_spec.rb b/spec/models/commentaire_spec.rb
index efcf9bff1..8decaf4ae 100644
--- a/spec/models/commentaire_spec.rb
+++ b/spec/models/commentaire_spec.rb
@@ -8,4 +8,56 @@ describe Commentaire do
   it { is_expected.to belong_to(:dossier) }
 
   it { is_expected.to belong_to(:piece_justificative) }
+
+  describe "#notify" do
+    let(:procedure) { create(:procedure) }
+    let(:gestionnaire) { create(:gestionnaire) }
+    let(:assign_to) { create(:assign_to, gestionnaire: gestionnaire, procedure: procedure) }
+    let(:user) { create(:user) }
+    let(:dossier) { create(:dossier, procedure: procedure, user: user) }
+    let(:commentaire) { Commentaire.new(dossier: dossier) }
+
+    context "with a commentaire created by a user" do
+      it "calls notify_gestionnaires" do
+        expect(commentaire).to receive(:notify_gestionnaires)
+
+        commentaire.email = user.email
+        commentaire.save
+      end
+    end
+
+    context "with a commentaire created by an invited user" do
+      let(:user_invite) { create(:user) }
+
+      before do
+        FactoryGirl.create(:invite_user, email: "invite@tps.apientreprise.fr", dossier: dossier, user: user_invite)
+      end
+
+      it "calls notify_gestionnaires" do
+        expect(commentaire).to receive(:notify_gestionnaires)
+
+        commentaire.email = user_invite.email
+        commentaire.save
+      end
+    end
+
+    context "with a commentaire created by a gestionnaire" do
+      it "calls notify_user" do
+        expect(commentaire).to receive(:notify_user)
+
+        commentaire.email = gestionnaire.email
+        commentaire.save
+      end
+    end
+
+    context "with a commentaire automatically created (notification)" do
+      it "does not call notify_user or notify_gestionnaires" do
+        expect(commentaire).not_to receive(:notify_user)
+        expect(commentaire).not_to receive(:notify_gestionnaires)
+
+        commentaire.email = "contact@tps.apientreprise.fr"
+        commentaire.save
+      end
+    end
+  end
 end