From 106263f5e724b4abea5b0956af98270abfa8708c Mon Sep 17 00:00:00 2001 From: simon lehericey Date: Fri, 13 Jul 2018 13:09:21 +0200 Subject: [PATCH] [fix #2247] linked drop down list: fix js scope pb --- .../new_design/champs/linked_drop_down_list.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/new_design/champs/linked_drop_down_list.js b/app/assets/javascripts/new_design/champs/linked_drop_down_list.js index d82bf438f..03e7cd692 100644 --- a/app/assets/javascripts/new_design/champs/linked_drop_down_list.js +++ b/app/assets/javascripts/new_design/champs/linked_drop_down_list.js @@ -1,14 +1,14 @@ document.addEventListener('turbolinks:load', function() { - var primaries, i, primary, secondary, secondaryOptions; + var primaries, i; primaries = document.querySelectorAll('select[data-secondary-options]'); for (i = 0; i < primaries.length; i++) { - primary = primaries[i]; - secondary = document.querySelector('select[data-secondary-id="' + primary.dataset.primaryId + '"]'); - secondaryOptions = JSON.parse(primary.dataset.secondaryOptions); + primaries[i].addEventListener('change', function(e) { + var option, options, element, primary, secondary, secondaryOptions; - primary.addEventListener('change', function(e) { - var option, options, element; + primary = e.target; + secondary = document.querySelector('select[data-secondary-id="' + primary.dataset.primaryId + '"]'); + secondaryOptions = JSON.parse(primary.dataset.secondaryOptions); while ((option = secondary.firstChild)) { secondary.removeChild(option);