From 7e03f0c8257c7e23ecd5c679862586f102d4cb1b Mon Sep 17 00:00:00 2001 From: simon lehericey Date: Fri, 7 Oct 2022 18:29:44 +0200 Subject: [PATCH] refactor(dossier_preloader): add load_one api --- app/controllers/users/dossiers_controller.rb | 2 +- app/models/dossier_preloader.rb | 4 ++++ spec/models/dossier_preloader_spec.rb | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/controllers/users/dossiers_controller.rb b/app/controllers/users/dossiers_controller.rb index 217d95f33..f878a4130 100644 --- a/app/controllers/users/dossiers_controller.rb +++ b/app/controllers/users/dossiers_controller.rb @@ -392,7 +392,7 @@ module Users end def dossier_with_champs - DossierPreloader.new([dossier]).all.first + DossierPreloader.load_one(dossier) end def should_change_groupe_instructeur? diff --git a/app/models/dossier_preloader.rb b/app/models/dossier_preloader.rb index 9e49256f7..8a566c2cf 100644 --- a/app/models/dossier_preloader.rb +++ b/app/models/dossier_preloader.rb @@ -17,6 +17,10 @@ class DossierPreloader dossiers end + def self.load_one(dossier) + DossierPreloader.new([dossier]).all.first + end + private # returns: { revision_id : { type_de_champ_id : position } } diff --git a/spec/models/dossier_preloader_spec.rb b/spec/models/dossier_preloader_spec.rb index 70cd8db30..f1de07b97 100644 --- a/spec/models/dossier_preloader_spec.rb +++ b/spec/models/dossier_preloader_spec.rb @@ -11,7 +11,7 @@ describe DossierPreloader do let(:first_child) { subject.champs.second.champs.first } describe 'all' do - subject { DossierPreloader.new([dossier]).all.first } + subject { DossierPreloader.load_one(dossier) } before { subject }