From 19813162db4ef0464e56268d63601f3a287607db Mon Sep 17 00:00:00 2001 From: Corinne Durrmeyer Date: Mon, 24 Jun 2024 15:34:00 +0200 Subject: [PATCH 1/5] Update titles --- config/locales/views/support/en.yml | 2 +- config/locales/views/support/fr.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/locales/views/support/en.yml b/config/locales/views/support/en.yml index 0fda6c690..8a79b8f54 100644 --- a/config/locales/views/support/en.yml +++ b/config/locales/views/support/en.yml @@ -19,7 +19,7 @@ en:

If you are facing technical issues on the website, use the form below. We will not be able to inform you about the instruction of your application.

" product: question: I have an idea to improve the website - answer_html: "

Got an idea? Please check our enhancement dashboard :

+ answer_html: "

Got an idea? Please check our enhancement dashboard :

" lost_user: diff --git a/config/locales/views/support/fr.yml b/config/locales/views/support/fr.yml index 8450f1692..944f3be40 100644 --- a/config/locales/views/support/fr.yml +++ b/config/locales/views/support/fr.yml @@ -19,7 +19,7 @@ fr:

Si vous souhaitez poser une question pour un problème technique sur le site, utilisez le formulaire ci-dessous. Nous ne pourrons pas vous renseigner sur l’instruction de votre dossier.

" product: question: J’ai une idée d’amélioration pour votre site - answer_html: "

Une idée ? Pensez à consulter notre tableau de bord des améliorations :

+ answer_html: "

Une idée ? Pensez à consulter notre tableau de bord des améliorations :

" lost_user: From 07f063829e998bb19a63a3569deddd5578f2d273 Mon Sep 17 00:00:00 2001 From: Corinne Durrmeyer Date: Mon, 24 Jun 2024 16:30:41 +0200 Subject: [PATCH 2/5] Remove forbidden attribute --- app/views/support/index.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/support/index.html.haml b/app/views/support/index.html.haml index 99fee2678..366dafad7 100644 --- a/app/views/support/index.html.haml +++ b/app/views/support/index.html.haml @@ -65,7 +65,7 @@ = t('.notice_pj_product') %p.notice.hidden{ data: { 'contact-type-only': Helpscout::FormAdapter::TYPE_AUTRE } } = t('.notice_pj_other') - = file_field_tag :piece_jointe, class: 'fr-upload', max: 200.megabytes + = file_field_tag :piece_jointe, class: 'fr-upload' = hidden_field_tag :tags, @tags&.join(',') From d82e84d711d507142d9e7b073968fecfe664b879 Mon Sep 17 00:00:00 2001 From: Corinne Durrmeyer Date: Tue, 25 Jun 2024 16:10:22 +0200 Subject: [PATCH 3/5] Add expected data type to email field --- app/views/support/index.html.haml | 1 + config/locales/views/support/en.yml | 1 + config/locales/views/support/fr.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/app/views/support/index.html.haml b/app/views/support/index.html.haml index 366dafad7..0c54a1c4e 100644 --- a/app/views/support/index.html.haml +++ b/app/views/support/index.html.haml @@ -18,6 +18,7 @@ .fr-input-group = label_tag :email, class: 'fr-label' do Email + = t('.notice_email') = render EditableChamp::AsteriskMandatoryComponent.new = email_field_tag :email, params[:email], required: true, autocomplete: 'email', class: 'fr-input' diff --git a/config/locales/views/support/en.yml b/config/locales/views/support/en.yml index 8a79b8f54..226327cbf 100644 --- a/config/locales/views/support/en.yml +++ b/config/locales/views/support/en.yml @@ -4,6 +4,7 @@ en: contact: Contact intro_html: "

Contact us via this form and we will answer you as quickly as possible.

Make sure you provide all the required information so we can help you in the best way.

" + notice_email: "(example: myaddress@mymail.com)" your_question: Your question our_answer: 👉 Our answer notice_pj_product: A screenshot can help us identify the element to improve. diff --git a/config/locales/views/support/fr.yml b/config/locales/views/support/fr.yml index 944f3be40..2e09606fc 100644 --- a/config/locales/views/support/fr.yml +++ b/config/locales/views/support/fr.yml @@ -4,6 +4,7 @@ fr: contact: Contact intro_html: "

Contactez-nous via ce formulaire et nous vous répondrons dans les plus brefs délais.

Pensez bien à nous donner le plus d’informations possible pour que nous puissions vous aider au mieux.

" + notice_email: "(exemple : monadresse@monmail.com)" your_question: Votre question our_answer: Notre réponse notice_pj_product: Une capture d’écran peut nous aider à identifier plus facilement l’endroit à améliorer. From e71d3301433b5b1289ca614ac823bed967cd6313 Mon Sep 17 00:00:00 2001 From: Corinne Durrmeyer Date: Tue, 25 Jun 2024 16:19:58 +0200 Subject: [PATCH 4/5] Remove icon to prevent it being vocalized by assistive technologies --- config/locales/views/support/en.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/locales/views/support/en.yml b/config/locales/views/support/en.yml index 226327cbf..a280d3746 100644 --- a/config/locales/views/support/en.yml +++ b/config/locales/views/support/en.yml @@ -6,7 +6,7 @@ en:

Make sure you provide all the required information so we can help you in the best way.

" notice_email: "(example: myaddress@mymail.com)" your_question: Your question - our_answer: 👉 Our answer + our_answer: Our answer notice_pj_product: A screenshot can help us identify the element to improve. notice_pj_other: A screenshot can help us identify the issue. notice_upload_group: "Maximum size: 200 MB. Supported formats: jpg, png, pdf." From 52b78a51d57844f5db557dc0d7af1d95fae45bf0 Mon Sep 17 00:00:00 2001 From: Corinne Durrmeyer Date: Tue, 25 Jun 2024 16:34:05 +0200 Subject: [PATCH 5/5] Restrict document selection to authorized types only --- app/views/support/index.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/support/index.html.haml b/app/views/support/index.html.haml index 0c54a1c4e..532cbab8e 100644 --- a/app/views/support/index.html.haml +++ b/app/views/support/index.html.haml @@ -66,7 +66,7 @@ = t('.notice_pj_product') %p.notice.hidden{ data: { 'contact-type-only': Helpscout::FormAdapter::TYPE_AUTRE } } = t('.notice_pj_other') - = file_field_tag :piece_jointe, class: 'fr-upload' + = file_field_tag :piece_jointe, class: 'fr-upload', accept: '.jpg, .jpeg, .png, .pdf' = hidden_field_tag :tags, @tags&.join(',')