From 6ab3fa1cf4fbc8dc8c71724b29a42015e0dba2c1 Mon Sep 17 00:00:00 2001
From: Colin Darie <colin@darie.eu>
Date: Mon, 5 Feb 2024 11:35:01 +0100
Subject: [PATCH] fix(rubocop): Rails/RedundantActiveRecordAllMethod

---
 app/controllers/manager/outdated_procedures_controller.rb     | 4 ++--
 app/models/procedure_revision_preloader.rb                    | 2 +-
 db/migrate/20220725070026_cleanup_assign_tos_from_betagouv.rb | 2 +-
 ...eadd_super_admin_to_their_procedure_without_instructeur.rb | 2 +-
 .../20230131132616_fix_dossier_transfer_with_uppercase.rake   | 2 +-
 lib/tasks/superadmin.rake                                     | 2 +-
 .../gestionnaires/groupe_gestionnaires_controller_spec.rb     | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/controllers/manager/outdated_procedures_controller.rb b/app/controllers/manager/outdated_procedures_controller.rb
index d51752d68..1d9e3c650 100644
--- a/app/controllers/manager/outdated_procedures_controller.rb
+++ b/app/controllers/manager/outdated_procedures_controller.rb
@@ -2,8 +2,8 @@ module Manager
   class OutdatedProceduresController < Manager::ApplicationController
     def index
       @records_per_page = params[:records_per_page] || "10"
-      resources = Procedure.all
-        .where(procedure_expires_when_termine_enabled: false)
+      resources = Procedure.
+        where(procedure_expires_when_termine_enabled: false)
         .order(created_at: :asc)
         .page(params[:_page])
         .per(@records_per_page)
diff --git a/app/models/procedure_revision_preloader.rb b/app/models/procedure_revision_preloader.rb
index 7109c186b..bd85517ba 100644
--- a/app/models/procedure_revision_preloader.rb
+++ b/app/models/procedure_revision_preloader.rb
@@ -9,7 +9,7 @@ class ProcedureRevisionPreloader
   end
 
   def self.load_one(revision)
-    ProcedureRevisionPreloader.new([revision]).all.first
+    ProcedureRevisionPreloader.new([revision]).all.first # rubocop:disable Rails/RedundantActiveRecordAllMethod
   end
 
   private
diff --git a/db/migrate/20220725070026_cleanup_assign_tos_from_betagouv.rb b/db/migrate/20220725070026_cleanup_assign_tos_from_betagouv.rb
index e58878c33..d8ea4dc9c 100644
--- a/db/migrate/20220725070026_cleanup_assign_tos_from_betagouv.rb
+++ b/db/migrate/20220725070026_cleanup_assign_tos_from_betagouv.rb
@@ -1,6 +1,6 @@
 class CleanupAssignTosFromBetagouv < ActiveRecord::Migration[6.1]
   def up
-    super_admin_emails = SuperAdmin.all.pluck(:email)
+    super_admin_emails = SuperAdmin.pluck(:email)
 
     super_admin_emails.each do |email|
       user = User.find_by(email: email)
diff --git a/db/migrate/20220824114151_readd_super_admin_to_their_procedure_without_instructeur.rb b/db/migrate/20220824114151_readd_super_admin_to_their_procedure_without_instructeur.rb
index 6d11b4763..212fafdea 100644
--- a/db/migrate/20220824114151_readd_super_admin_to_their_procedure_without_instructeur.rb
+++ b/db/migrate/20220824114151_readd_super_admin_to_their_procedure_without_instructeur.rb
@@ -1,6 +1,6 @@
 class ReaddSuperAdminToTheirProcedureWithoutInstructeur < ActiveRecord::Migration[6.1]
   def change
-    super_admin_emails = SuperAdmin.all.pluck(:email)
+    super_admin_emails = SuperAdmin.pluck(:email)
     # we want to re-assign each super admin being an admin of a procedure
     # to every procedure that lost all instructeur
     # so we cache procedure without instructeur first
diff --git a/lib/tasks/deployment/20230131132616_fix_dossier_transfer_with_uppercase.rake b/lib/tasks/deployment/20230131132616_fix_dossier_transfer_with_uppercase.rake
index 55db50e00..ed89182c7 100644
--- a/lib/tasks/deployment/20230131132616_fix_dossier_transfer_with_uppercase.rake
+++ b/lib/tasks/deployment/20230131132616_fix_dossier_transfer_with_uppercase.rake
@@ -4,7 +4,7 @@ namespace :after_party do
     puts "Running deploy task 'fix_dossier_transfer_with_uppercase'"
     # in production, about 1000, no need to track progress
 
-    DossierTransfer.all.find_each do |dt|
+    DossierTransfer.find_each do |dt|
       if /A-Z/.match?(dt.email)
         dt.email = dt.email.downcase
         dt.save
diff --git a/lib/tasks/superadmin.rake b/lib/tasks/superadmin.rake
index 9579f3af4..77cea6374 100644
--- a/lib/tasks/superadmin.rake
+++ b/lib/tasks/superadmin.rake
@@ -6,7 +6,7 @@ namespace :superadmin do
   EOD
   task list: :environment do
     rake_puts "All SuperAdmins:"
-    SuperAdmin.all.pluck(:email).each do |a|
+    SuperAdmin.pluck(:email).each do |a|
       puts a
     end
   end
diff --git a/spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb b/spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb
index 7faee5eb4..9c11cb02d 100644
--- a/spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb
+++ b/spec/controllers/gestionnaires/groupe_gestionnaires_controller_spec.rb
@@ -123,7 +123,7 @@ describe Gestionnaires::GroupeGestionnairesController, type: :controller do
 
       it do
         subject
-        expect(GroupeGestionnaire.all.count).to eq(1)
+        expect(GroupeGestionnaire.count).to eq(1)
         expect(response).to redirect_to(gestionnaire_groupe_gestionnaires_path)
       end
     end