diff --git a/app/lib/biz_dev.rb b/app/lib/biz_dev.rb index 65170e127..d4a50b4ff 100644 --- a/app/lib/biz_dev.rb +++ b/app/lib/biz_dev.rb @@ -24,13 +24,13 @@ module BizDev BIZ_DEV_IDS = BIZ_DEV_MAPPING.keys - def full_name(administration_id) + def self.full_name(administration_id) id = ensure_proper_administration_id(administration_id) BIZ_DEV_MAPPING[id][:full_name] end - def pipedrive_id(administration_id) + def self.pipedrive_id(administration_id) id = ensure_proper_administration_id(administration_id) BIZ_DEV_MAPPING[id][:pipedrive_id] @@ -38,7 +38,7 @@ module BizDev private - def ensure_proper_administration_id(administration_id) + def self.ensure_proper_administration_id(administration_id) if administration_id.in?(BIZ_DEV_IDS) administration_id else diff --git a/spec/lib/biz_dev_spec.rb b/spec/lib/biz_dev_spec.rb new file mode 100644 index 000000000..e5a59ba5e --- /dev/null +++ b/spec/lib/biz_dev_spec.rb @@ -0,0 +1,40 @@ +require 'spec_helper' + +describe BizDev, lib: true do + let(:first_biz_dev_id) { BizDev::BIZ_DEV_IDS.first } + let(:non_biz_dev_id) { first_biz_dev_id - 1 } + + it { expect(BizDev::BIZ_DEV_MAPPING).not_to include(non_biz_dev_id) } + + describe '#full_name' do + subject { described_class.full_name(administration_id) } + + context 'when administration is a business developer' do + let(:administration_id) { first_biz_dev_id } + + it { is_expected.not_to be_empty } + end + + context 'when administration is not a business developer' do + let(:administration_id) { non_biz_dev_id } + + it { is_expected.not_to be_empty } + end + end + + describe '#pipedrive_id' do + subject { described_class.pipedrive_id(administration_id) } + + context 'when administration is a business developer' do + let(:administration_id) { first_biz_dev_id } + + it { is_expected.to be > 0 } + end + + context 'when administration is not a business developer' do + let(:administration_id) { non_biz_dev_id } + + it { is_expected.to be > 0 } + end + end +end