diff --git a/app/controllers/experts/avis_controller.rb b/app/controllers/experts/avis_controller.rb index 6523fcd2c..a298d4485 100644 --- a/app/controllers/experts/avis_controller.rb +++ b/app/controllers/experts/avis_controller.rb @@ -139,7 +139,7 @@ module Experts end def telecharger_pjs - files = ActiveStorage::DownloadableFile.create_list_from_dossier(@dossier, true) + files = ActiveStorage::DownloadableFile.create_list_from_dossiers(Dossier.where(id: @dossier.id), true) zipline(files, "dossier-#{@dossier.id}.zip") end diff --git a/app/controllers/instructeurs/dossiers_controller.rb b/app/controllers/instructeurs/dossiers_controller.rb index 8612359ea..e941f50e3 100644 --- a/app/controllers/instructeurs/dossiers_controller.rb +++ b/app/controllers/instructeurs/dossiers_controller.rb @@ -218,7 +218,7 @@ module Instructeurs end def telecharger_pjs - files = ActiveStorage::DownloadableFile.create_list_from_dossier(dossier) + files = ActiveStorage::DownloadableFile.create_list_from_dossiers(Dossier.where(id: dossier.id)) zipline(files, "dossier-#{dossier.id}.zip") end diff --git a/app/lib/active_storage/downloadable_file.rb b/app/lib/active_storage/downloadable_file.rb index 15895ccc6..85a3c586f 100644 --- a/app/lib/active_storage/downloadable_file.rb +++ b/app/lib/active_storage/downloadable_file.rb @@ -10,9 +10,9 @@ class ActiveStorage::DownloadableFile end end - def self.create_list_from_dossiers(dossiers) + def self.create_list_from_dossiers(dossiers, for_expert = false) dossiers.flat_map do |dossier| - create_list_from_dossier(dossier) + create_list_from_dossier(dossier, for_expert) end end diff --git a/spec/lib/active_storage/downloadable_file_spec.rb b/spec/lib/active_storage/downloadable_file_spec.rb index 755a0643c..011614265 100644 --- a/spec/lib/active_storage/downloadable_file_spec.rb +++ b/spec/lib/active_storage/downloadable_file_spec.rb @@ -1,9 +1,9 @@ describe ActiveStorage::DownloadableFile do let(:dossier) { create(:dossier, :en_construction) } - subject(:list) { ActiveStorage::DownloadableFile.create_list_from_dossier(dossier) } + subject(:list) { ActiveStorage::DownloadableFile.create_list_from_dossiers(Dossier.where(id: dossier.id)) } - describe 'create_list_from_dossier' do + describe 'create_list_from_dossiers' do context 'when no piece_justificative is present' do it { expect(list.length).to eq 1 } it { expect(list.first[0].name).to eq "pdf_export_for_instructeur" } @@ -60,7 +60,7 @@ describe ActiveStorage::DownloadableFile do let(:champ) { dossier.champs.first } let(:avis) { create(:avis, dossier: dossier, claimant: instructeur, experts_procedure: experts_procedure, confidentiel: true) } - subject(:list) { ActiveStorage::DownloadableFile.create_list_from_dossier(dossier, true) } + subject(:list) { ActiveStorage::DownloadableFile.create_list_from_dossiers(Dossier.where(id: dossier.id), true) } before do dossier.champs_private << create(:champ_piece_justificative, :with_piece_justificative_file, private: true, dossier: dossier)