DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feedbacks from Martin

Browse source
This commit is contained in:
Lisa Durand 2023-01-05 15:10:07 +01:00
parent 3918757dc9
commit 4afb873afc
3 changed files with 42 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/assets/stylesheets/buttons.scss
View file

@ -273,7 +273,6 @@ ul.dropdown-items {
margin: -$default-padding; margin: -$default-padding;
padding: $default-padding; padding: $default-padding;
text-align: left; text-align: left;
font-size: 12px;
} }
.icon { .icon {

1
app/components/dossiers/batch_operation_component/batch_operation_component.html.haml
View file

@ -1,4 +1,3 @@
- if available_operations[:options].present?
- if available_operations[:options].count == 1 - if available_operations[:options].count == 1
- opt = available_operations[:options].dig(0) - opt = available_operations[:options].dig(0)
= form_for(BatchOperation.new, url: instructeur_batch_operations_path(procedure_id: procedure.id), method: :post, html: { class: 'flex justify-end', id: "#{dom_id(BatchOperation.new)}" }, data: { "batch-operation-target" => "form"}) do |form| = form_for(BatchOperation.new, url: instructeur_batch_operations_path(procedure_id: procedure.id), method: :post, html: { class: 'flex justify-end', id: "#{dom_id(BatchOperation.new)}" }, data: { "batch-operation-target" => "form"}) do |form|

2
app/models/batch_operation.rb
View file

@ -78,7 +78,6 @@ class BatchOperation < ApplicationRecord
end end
def track_processed_dossier(success, dossier) def track_processed_dossier(success, dossier)
transaction do
dossiers.delete(dossier) dossiers.delete(dossier)
touch(:run_at) if called_for_first_time? touch(:run_at) if called_for_first_time?
touch(:finished_at) if called_for_last_time?(dossier) touch(:finished_at) if called_for_last_time?(dossier)
@ -89,7 +88,6 @@ class BatchOperation < ApplicationRecord
dossier_operation(dossier).fail! dossier_operation(dossier).fail!
end end
end end
end
# when an instructeur want to create a batch from his interface, # when an instructeur want to create a batch from his interface,
# another one might have run something on one of the dossier # another one might have run something on one of the dossier