From 420520489df7f91efedf7b1257ec131113b849da Mon Sep 17 00:00:00 2001
From: simon lehericey <mail@simon.lehericey.net>
Date: Wed, 15 May 2024 09:30:38 +0200
Subject: [PATCH] refactor(tags_substitution): simplify

---
 app/models/concerns/tags_substitution_concern.rb | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/app/models/concerns/tags_substitution_concern.rb b/app/models/concerns/tags_substitution_concern.rb
index e68dae815..c9b7262af 100644
--- a/app/models/concerns/tags_substitution_concern.rb
+++ b/app/models/concerns/tags_substitution_concern.rb
@@ -284,13 +284,10 @@ module TagsSubstitutionConcern
     @escape_unsafe_tags = escape
 
     if @flat_tags.nil?
-      @flat_tags = available_tags(dossier).each_with_object({}) do |tags, result|
-        valid_tags = tags_for_dossier_state(tags)
-
-        valid_tags.each do |tag|
-          result[tag[:id]] = tag
-        end
-      end
+      @flat_tags = available_tags(dossier)
+        .flatten
+        .then { tags_for_dossier_state(_1) }
+        .index_by { _1[:id] }
     end
 
     tags_and_libelles.each_with_object({}) do |(tag_id, libelle), substitutions|