From 39613ed67d0ead5b0ec74392a54f50c4de5a468e Mon Sep 17 00:00:00 2001 From: Paul Chavard Date: Mon, 24 Jul 2023 18:22:35 +0200 Subject: [PATCH] fix(a11y): add label and remove non unique id --- .../user_filter_component/user_filter_component.html.haml | 4 ++-- .../user_procedure_filter_component.en.yml | 1 + .../user_procedure_filter_component.fr.yml | 1 + .../user_procedure_filter_component.html.haml | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/components/dossiers/user_filter_component/user_filter_component.html.haml b/app/components/dossiers/user_filter_component/user_filter_component.html.haml index 603eda044..06d0cfca4 100644 --- a/app/components/dossiers/user_filter_component/user_filter_component.html.haml +++ b/app/components/dossiers/user_filter_component/user_filter_component.html.haml @@ -6,9 +6,9 @@ = t('.button.select_filters') #filters.fr-collapse.fr-translate__menu.fr-menu %ul.fr-menu__list.fr-p-3w - = form_with(url: dossiers_path(), method: :get ) do |f| + = form_with(url: dossiers_path, method: :get ) do |f| = f.hidden_field :statut, value: @statut - = f.hidden_field :procedure_id, value: @procedure_id + = f.hidden_field :procedure_id, value: @procedure_id, id: nil .fr-input-group = f.label :state, t('.legend.state'), class: 'fr-label' diff --git a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.en.yml b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.en.yml index 45c1425e5..d6e123c4a 100644 --- a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.en.yml +++ b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.en.yml @@ -1,3 +1,4 @@ fr: procedures: + label: Filter by procedure prompt: All procedures diff --git a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.fr.yml b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.fr.yml index cef208e21..ae421496a 100644 --- a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.fr.yml +++ b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.fr.yml @@ -1,3 +1,4 @@ fr: procedures: + label: Filtrer par démarche prompt: Toutes les démarches diff --git a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.html.haml b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.html.haml index 520ddee65..bca9ee4aa 100644 --- a/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.html.haml +++ b/app/components/dossiers/user_procedure_filter_component/user_procedure_filter_component.html.haml @@ -1,3 +1,4 @@ = form_with(url: dossiers_path, method: :get, data: { controller: 'autosubmit' } ) do |f| + = f.label :procedure_id, t('.procedure.label'), class: 'sr-only' .fr-input-group = f.select :procedure_id, options_for_select(@procedures_for_select, params[:procedure_id]), { prompt: t('.procedures.prompt') }, class: 'fr-select'