From b6fbf9bd4b3c442773f210c338ab829a1be1f627 Mon Sep 17 00:00:00 2001 From: Pierre de La Morinerie Date: Mon, 6 Jul 2020 16:08:28 +0000 Subject: [PATCH 1/2] gems: update scss_lint Fix false-positive on pseudo-elements. --- Gemfile.lock | 9 ++++----- app/assets/stylesheets/new_design/procedure_context.scss | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index efd583670..c52ab8dda 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -227,7 +227,7 @@ GEM activesupport (>= 3.0.0) faraday (0.15.4) multipart-post (>= 1.2, < 3) - ffi (1.12.2) + ffi (1.13.1) ffi-geos (2.1.0) ffi (>= 1.0.0) flipper (0.17.2) @@ -525,9 +525,9 @@ GEM rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) rainbow (3.0.0) - rake (12.3.3) + rake (13.0.1) rake-progressbar (0.0.5) - rb-fsevent (0.10.3) + rb-fsevent (0.10.4) rb-inotify (0.10.1) ffi (~> 1.0) react-rails (2.4.7) @@ -620,8 +620,7 @@ GEM sprockets (> 3.0) sprockets-rails tilt - scss_lint (0.57.1) - rake (>= 0.9, < 13) + scss_lint (0.59.0) sass (~> 3.5, >= 3.5.5) selectize-rails (0.12.6) selenium-webdriver (3.141.0) diff --git a/app/assets/stylesheets/new_design/procedure_context.scss b/app/assets/stylesheets/new_design/procedure_context.scss index f30713c23..37ba7feb9 100644 --- a/app/assets/stylesheets/new_design/procedure_context.scss +++ b/app/assets/stylesheets/new_design/procedure_context.scss @@ -51,7 +51,7 @@ $procedure-description-line-height: 22px; summary { font-size: 20px; - &:-webkit-details-marker { + &::-webkit-details-marker { display: none; } } From c3b648f9753a1ff822789acb9339b98a459fa19a Mon Sep 17 00:00:00 2001 From: Pierre de La Morinerie Date: Mon, 6 Jul 2020 18:09:41 +0200 Subject: [PATCH 2/2] stylesheets: hide summary details marker on procedure summary Chrome needs a specific syntax, but other browsers use the standard way. See developer.mozilla.org/fr/docs/Web/HTML/Element/details#Personnaliser_le_marqueur_de_r%C3%A9v%C3%A9lation --- app/assets/stylesheets/new_design/procedure_context.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/assets/stylesheets/new_design/procedure_context.scss b/app/assets/stylesheets/new_design/procedure_context.scss index 37ba7feb9..965c2408f 100644 --- a/app/assets/stylesheets/new_design/procedure_context.scss +++ b/app/assets/stylesheets/new_design/procedure_context.scss @@ -51,6 +51,9 @@ $procedure-description-line-height: 22px; summary { font-size: 20px; + // Hide the default triangle details marker + list-style: none; + // (using the non-standard way for Chrome.) &::-webkit-details-marker { display: none; }