From 348b15f595a793cef5b790001b4d61328c7e305f Mon Sep 17 00:00:00 2001
From: Paul Chavard <git@paul.chavard.net>
Date: Wed, 15 May 2019 15:57:57 +0200
Subject: [PATCH] Put devtools behind feature flags

---
 app/controllers/application_controller.rb | 2 +-
 app/views/layouts/application.html.haml   | 4 ++--
 config/features.rb                        | 7 +++++++
 config/initializers/rack_mini_profiler.rb | 1 +
 4 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 config/initializers/rack_mini_profiler.rb

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 8ab881d8b..5dbfd7a61 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -24,7 +24,7 @@ class ApplicationController < ActionController::Base
   end
 
   def authorize_request_for_profiler
-    if administration_signed_in?
+    if Flipflop.mini_profiler_enabled?
       Rack::MiniProfiler.authorize_request
     end
   end
diff --git a/app/views/layouts/application.html.haml b/app/views/layouts/application.html.haml
index 5a0486f44..2eb205c1a 100644
--- a/app/views/layouts/application.html.haml
+++ b/app/views/layouts/application.html.haml
@@ -21,7 +21,7 @@
 
     = Gon::Base.render_data(camel_case: true, init: true, nonce:  request.content_security_policy_nonce)
 
-    - if Rails.env.development?
+    - if Flipflop.xray_enabled?
       = stylesheet_link_tag :xray
 
   %body{ id: content_for(:page_id), class: browser.platform.ios? ? 'ios' : nil }
@@ -39,7 +39,7 @@
       - if content_for?(:footer)
         = content_for(:footer)
 
-      - if Rails.env.development?
+      - if Flipflop.xray_enabled?
         = javascript_include_tag :xray
 
       = yield :charts_js
diff --git a/config/features.rb b/config/features.rb
index 4c2516549..38dd51141 100644
--- a/config/features.rb
+++ b/config/features.rb
@@ -18,6 +18,13 @@ Flipflop.configure do
 
   feature :operation_log_serialize_subject
 
+  group :development do
+    feature :mini_profiler_enabled,
+      default: Rails.env.development?
+    feature :xray_enabled,
+      default: Rails.env.development?
+  end
+
   group :production do
     feature :remote_storage,
       default: ENV['FOG_ENABLED'] == 'enabled'
diff --git a/config/initializers/rack_mini_profiler.rb b/config/initializers/rack_mini_profiler.rb
new file mode 100644
index 000000000..5065ab5cd
--- /dev/null
+++ b/config/initializers/rack_mini_profiler.rb
@@ -0,0 +1 @@
+Rack::MiniProfiler.config.authorization_mode = :whitelist