From 58b110b88a378b3ab14b42e5581097bf1c9ca4bd Mon Sep 17 00:00:00 2001 From: clemkeirua Date: Thu, 4 Jun 2020 21:43:55 +0200 Subject: [PATCH 1/3] invalid image width '-_- --- app/views/layouts/_new_header.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/layouts/_new_header.haml b/app/views/layouts/_new_header.haml index d2734cadd..02cd3e321 100644 --- a/app/views/layouts/_new_header.haml +++ b/app/views/layouts/_new_header.haml @@ -20,7 +20,7 @@ - else - root_profile_link, root_profile_libelle = root_path_info_for_profile(nav_bar_profile) = link_to root_profile_link, class: 'header-logo justify-center', title: root_profile_libelle do - = image_tag 'marianne.svg', alt: 'Liberté, égalité, fraternité', width: '65px' + = image_tag 'marianne.svg', alt: 'Liberté, égalité, fraternité', width: '65' %span.big.site-title> demarches-simplifiees.fr %span.small.site-title> d-s.fr From cca84a62cafe10b45e5c864efd574379fd2970f3 Mon Sep 17 00:00:00 2001 From: clemkeirua Date: Wed, 10 Jun 2020 11:16:46 +0200 Subject: [PATCH 2/3] meilleurs descriptions aria au signup --- app/views/users/registrations/new.html.haml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/users/registrations/new.html.haml b/app/views/users/registrations/new.html.haml index 87ca878f2..054ee5a77 100644 --- a/app/views/users/registrations/new.html.haml +++ b/app/views/users/registrations/new.html.haml @@ -5,8 +5,8 @@ = form_for resource, url: user_registration_path, html: { class: "form" } do |f| %h1 Créez-vous un compte demarches-simplifiees.fr - = f.label :email, "Email (nom@site.com)" - = f.text_field :email, type: :email, autocomplete: 'username', autofocus: true, placeholder: "Votre adresse email" + = f.label :email, "Email (nom@site.com)", id: :user_email_label + = f.text_field :email, type: :email, autocomplete: 'username', autofocus: true, placeholder: "Votre adresse email", 'aria-describedby': :user_email_label .suspect-email.hidden .email-suggestion-title @@ -19,8 +19,8 @@ = button_tag type: 'button', class: 'button small', onclick: "DS.discardEmailSuggestionBox()" do Non - = f.label :password, "Mot de passe (#{PASSWORD_MIN_LENGTH} caractères minimum)" - = f.password_field :password, autocomplete: 'new-password', value: @user.password, placeholder: "#{PASSWORD_MIN_LENGTH} caractères minimum", 'aria-describedby':'8 caractères minimum' + = f.label :password, "Mot de passe (#{PASSWORD_MIN_LENGTH} caractères minimum)", id: :user_password_label + = f.password_field :password, autocomplete: 'new-password', value: @user.password, placeholder: "#{PASSWORD_MIN_LENGTH} caractères minimum", 'aria-describedby': :user_password_label = f.submit "Créer un compte", class: "button large primary expand" From 53ecd48be277388626c430fbee091655b4e4b3a9 Mon Sep 17 00:00:00 2001 From: clemkeirua Date: Mon, 15 Jun 2020 15:17:40 +0200 Subject: [PATCH 3/3] set email autocomplete during registration username is an invalid autocomplete attribute for input type=email, but email is not --- app/views/users/registrations/new.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/users/registrations/new.html.haml b/app/views/users/registrations/new.html.haml index 054ee5a77..f5ea954a0 100644 --- a/app/views/users/registrations/new.html.haml +++ b/app/views/users/registrations/new.html.haml @@ -6,7 +6,7 @@ %h1 Créez-vous un compte demarches-simplifiees.fr = f.label :email, "Email (nom@site.com)", id: :user_email_label - = f.text_field :email, type: :email, autocomplete: 'username', autofocus: true, placeholder: "Votre adresse email", 'aria-describedby': :user_email_label + = f.text_field :email, type: :email, autocomplete: 'email', autofocus: true, placeholder: "Votre adresse email", 'aria-describedby': :user_email_label .suspect-email.hidden .email-suggestion-title