From 24e7537c49d9926faede4dbe2afbef5a982424dd Mon Sep 17 00:00:00 2001 From: gregoirenovel Date: Mon, 12 Jun 2017 16:01:04 +0200 Subject: [PATCH] Enable the Layout/EmptyLinesAroundClassBody cop --- .rubocop.yml | 2 +- app/controllers/api/v1/procedures_controller.rb | 1 - app/controllers/backoffice/avis_controller.rb | 1 - app/controllers/backoffice/dossiers/procedure_controller.rb | 1 - app/decorators/dossiers_decorator.rb | 1 - app/decorators/etablissement_decorator.rb | 1 - app/decorators/procedure_decorator.rb | 1 - app/decorators/procedures_decorator.rb | 1 - app/decorators/type_de_champ_decorator.rb | 1 - app/decorators/type_de_champ_private_decorator.rb | 1 - app/facades/dossier_facades.rb | 1 - app/facades/dossiers_list_facades.rb | 1 - app/facades/invite_dossier_facades.rb | 1 - app/lib/carto/geo_api/driver.rb | 2 -- app/mailers/avis_mailer.rb | 2 -- app/mailers/gestionnaire_mailer.rb | 1 - app/mailers/invite_mailer.rb | 1 - app/models/champ_private.rb | 1 - app/models/champ_public.rb | 1 - app/models/invite.rb | 1 - app/models/invite_gestionnaire.rb | 1 - app/models/invite_user.rb | 1 - app/models/type_de_champ_private.rb | 1 - app/models/type_de_champ_public.rb | 1 - app/services/browser_service.rb | 2 -- app/services/dossier_service.rb | 1 - app/services/dossiers_list_gestionnaire_service.rb | 1 - app/services/france_connect_salt_service.rb | 1 - app/services/notification_service.rb | 1 - app/services/render_partial_service.rb | 1 - app/services/sync_credentials_service.rb | 1 - app/services/user_routes_authorization_service.rb | 1 - app/uploaders/procedure_logo_uploader.rb | 2 -- app/validators/email_format_validator.rb | 1 - app/validators/procedure_path_format_validator.rb | 2 -- config/initializers/stringupcasepatch.rb | 2 -- db/migrate/20151207140202_update_module_api_carto.rb | 3 --- .../20160120094750_create_france_connect_information.rb | 3 --- db/migrate/20160317144949_piece_justificative_have_user.rb | 1 - db/migrate/20160317153115_cerfa_have_user.rb | 1 - .../20160524093540_set_original_filename_for_uploaders.rb | 2 -- .../20160609145737_delete_default_description_to_dossier.rb | 4 ---- ...20160622081321_convert_all_datetime_to_date_on_database.rb | 2 -- .../20160803081304_fix_default_type_on_type_de_champ_table.rb | 1 - db/migrate/20160804130638_add_type_attr_in_champ_table.rb | 1 - db/migrate/20160822142045_delete_value_of_filter_procedure.rb | 1 - ...0160901082824_initiated_all_received_mail_for_procedure.rb | 1 - ...248_change_emptyto_nil_in_preference_list_dossier_table.rb | 1 - ...42_fix_type_de_champ_header_section_with_mandatory_true.rb | 1 - .../20161007095443_reset_all_preference_list_dossier.rb | 1 - spec/mailers/previews/avis_mailer_preview.rb | 2 -- spec/mailers/previews/notification_mailer_preview.rb | 2 -- 52 files changed, 1 insertion(+), 69 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index e11f5c153..3a537645c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -55,7 +55,7 @@ Layout/EmptyLinesAroundBlockBody: Enabled: true Layout/EmptyLinesAroundClassBody: - Enabled: false + Enabled: true Layout/EmptyLinesAroundExceptionHandlingKeywords: Enabled: false diff --git a/app/controllers/api/v1/procedures_controller.rb b/app/controllers/api/v1/procedures_controller.rb index cf370a8ff..74895e845 100644 --- a/app/controllers/api/v1/procedures_controller.rb +++ b/app/controllers/api/v1/procedures_controller.rb @@ -13,5 +13,4 @@ class API::V1::ProceduresController < APIController Rails.logger.error(e.message) render json: {}, status: 404 end - end diff --git a/app/controllers/backoffice/avis_controller.rb b/app/controllers/backoffice/avis_controller.rb index 4d77496d2..5271626c7 100644 --- a/app/controllers/backoffice/avis_controller.rb +++ b/app/controllers/backoffice/avis_controller.rb @@ -1,5 +1,4 @@ class Backoffice::AvisController < ApplicationController - before_action :authenticate_gestionnaire!, except: [:sign_up, :create_gestionnaire] before_action :redirect_if_no_sign_up_needed, only: [:sign_up] before_action :check_avis_exists_and_email_belongs_to_avis, only: [:sign_up, :create_gestionnaire] diff --git a/app/controllers/backoffice/dossiers/procedure_controller.rb b/app/controllers/backoffice/dossiers/procedure_controller.rb index 5f96c1508..00ccbb3b5 100644 --- a/app/controllers/backoffice/dossiers/procedure_controller.rb +++ b/app/controllers/backoffice/dossiers/procedure_controller.rb @@ -21,5 +21,4 @@ class Backoffice::Dossiers::ProcedureController < Backoffice::DossiersListContro def retrieve_procedure current_gestionnaire.procedures.find params[:id] end - end diff --git a/app/decorators/dossiers_decorator.rb b/app/decorators/dossiers_decorator.rb index 6e8571b6f..159bb6aa9 100644 --- a/app/decorators/dossiers_decorator.rb +++ b/app/decorators/dossiers_decorator.rb @@ -1,4 +1,3 @@ class DossiersDecorator < Draper::CollectionDecorator delegate :current_page, :per_page, :offset, :total_entries, :total_pages - end diff --git a/app/decorators/etablissement_decorator.rb b/app/decorators/etablissement_decorator.rb index 23f809c79..b6e03db6a 100644 --- a/app/decorators/etablissement_decorator.rb +++ b/app/decorators/etablissement_decorator.rb @@ -1,4 +1,3 @@ class EtablissementDecorator < Draper::Decorator delegate_all - end diff --git a/app/decorators/procedure_decorator.rb b/app/decorators/procedure_decorator.rb index 561e6754b..50f64c2ab 100644 --- a/app/decorators/procedure_decorator.rb +++ b/app/decorators/procedure_decorator.rb @@ -1,5 +1,4 @@ class ProcedureDecorator < Draper::Decorator - delegate_all def lien diff --git a/app/decorators/procedures_decorator.rb b/app/decorators/procedures_decorator.rb index 380965078..7059df10d 100644 --- a/app/decorators/procedures_decorator.rb +++ b/app/decorators/procedures_decorator.rb @@ -1,4 +1,3 @@ class ProceduresDecorator < Draper::CollectionDecorator delegate :current_page, :per_page, :offset, :total_entries, :total_pages - end diff --git a/app/decorators/type_de_champ_decorator.rb b/app/decorators/type_de_champ_decorator.rb index d54293195..32cbbbdd6 100644 --- a/app/decorators/type_de_champ_decorator.rb +++ b/app/decorators/type_de_champ_decorator.rb @@ -1,5 +1,4 @@ class TypeDeChampDecorator < Draper::Decorator - delegate_all def button_up params diff --git a/app/decorators/type_de_champ_private_decorator.rb b/app/decorators/type_de_champ_private_decorator.rb index 31d4d3299..ea9f715a2 100644 --- a/app/decorators/type_de_champ_private_decorator.rb +++ b/app/decorators/type_de_champ_private_decorator.rb @@ -1,3 +1,2 @@ class TypeDeChampPrivateDecorator < TypeDeChampDecorator - end diff --git a/app/facades/dossier_facades.rb b/app/facades/dossier_facades.rb index 6d707f7fc..dfb7f73ab 100644 --- a/app/facades/dossier_facades.rb +++ b/app/facades/dossier_facades.rb @@ -1,5 +1,4 @@ class DossierFacades - #TODO rechercher en fonction de la personne/email def initialize(dossier_id, email, champ_id = nil) @dossier = Dossier.find(dossier_id) diff --git a/app/facades/dossiers_list_facades.rb b/app/facades/dossiers_list_facades.rb index 0a05a4148..ac9cc952c 100644 --- a/app/facades/dossiers_list_facades.rb +++ b/app/facades/dossiers_list_facades.rb @@ -80,5 +80,4 @@ class DossiersListFacades def base_url liste @procedure.nil? ? backoffice_dossiers_path(liste: liste) : backoffice_dossiers_procedure_path(id: @procedure.id, liste: liste) end - end diff --git a/app/facades/invite_dossier_facades.rb b/app/facades/invite_dossier_facades.rb index ce52f0b3c..6aaad2450 100644 --- a/app/facades/invite_dossier_facades.rb +++ b/app/facades/invite_dossier_facades.rb @@ -1,5 +1,4 @@ class InviteDossierFacades < DossierFacades - #TODO rechercher en fonction de la personne/email def initialize id, email @dossier = Invite.where(email: email, id: id).first!.dossier diff --git a/app/lib/carto/geo_api/driver.rb b/app/lib/carto/geo_api/driver.rb index 01825be40..d37e17e87 100644 --- a/app/lib/carto/geo_api/driver.rb +++ b/app/lib/carto/geo_api/driver.rb @@ -1,7 +1,6 @@ module Carto module GeoAPI class Driver - def self.regions call regions_url end @@ -29,7 +28,6 @@ module Carto rescue RestClient::ServiceUnavailable nil end - end end end diff --git a/app/mailers/avis_mailer.rb b/app/mailers/avis_mailer.rb index cf435cefc..c84d6a74e 100644 --- a/app/mailers/avis_mailer.rb +++ b/app/mailers/avis_mailer.rb @@ -1,9 +1,7 @@ class AvisMailer < ApplicationMailer - def avis_invitation(avis) @avis = avis email = @avis.gestionnaire.try(:email) || @avis.email mail(to: email, subject: "Donnez votre avis sur le dossier nº #{@avis.dossier.id} (#{@avis.dossier.procedure.libelle})") end - end diff --git a/app/mailers/gestionnaire_mailer.rb b/app/mailers/gestionnaire_mailer.rb index 118537a8d..e5ea4ed91 100644 --- a/app/mailers/gestionnaire_mailer.rb +++ b/app/mailers/gestionnaire_mailer.rb @@ -1,5 +1,4 @@ class GestionnaireMailer < ApplicationMailer - def new_gestionnaire email, password send_mail email, password, "Vous avez été nommé accompagnateur sur la plateforme TPS" end diff --git a/app/mailers/invite_mailer.rb b/app/mailers/invite_mailer.rb index 09b58f229..a7d6e4d8d 100644 --- a/app/mailers/invite_mailer.rb +++ b/app/mailers/invite_mailer.rb @@ -1,5 +1,4 @@ class InviteMailer < ApplicationMailer - def invite_user invite vars_mailer invite diff --git a/app/models/champ_private.rb b/app/models/champ_private.rb index 6f7068148..118e58415 100644 --- a/app/models/champ_private.rb +++ b/app/models/champ_private.rb @@ -1,3 +1,2 @@ class ChampPrivate < Champ - end diff --git a/app/models/champ_public.rb b/app/models/champ_public.rb index 7b0efcb3d..c922614ae 100644 --- a/app/models/champ_public.rb +++ b/app/models/champ_public.rb @@ -1,3 +1,2 @@ class ChampPublic < Champ - end diff --git a/app/models/invite.rb b/app/models/invite.rb index de2e45fca..dde8b2c6f 100644 --- a/app/models/invite.rb +++ b/app/models/invite.rb @@ -1,5 +1,4 @@ class Invite < ActiveRecord::Base - belongs_to :dossier belongs_to :user diff --git a/app/models/invite_gestionnaire.rb b/app/models/invite_gestionnaire.rb index 6021286da..fabc49f36 100644 --- a/app/models/invite_gestionnaire.rb +++ b/app/models/invite_gestionnaire.rb @@ -1,3 +1,2 @@ class InviteGestionnaire < Invite - end diff --git a/app/models/invite_user.rb b/app/models/invite_user.rb index 05ec141e9..c599c2f23 100644 --- a/app/models/invite_user.rb +++ b/app/models/invite_user.rb @@ -1,3 +1,2 @@ class InviteUser < Invite - end diff --git a/app/models/type_de_champ_private.rb b/app/models/type_de_champ_private.rb index 1b4e7ed3f..ba6e89a82 100644 --- a/app/models/type_de_champ_private.rb +++ b/app/models/type_de_champ_private.rb @@ -1,3 +1,2 @@ class TypeDeChampPrivate < TypeDeChamp - end diff --git a/app/models/type_de_champ_public.rb b/app/models/type_de_champ_public.rb index 8e9fb760d..3be990e13 100644 --- a/app/models/type_de_champ_public.rb +++ b/app/models/type_de_champ_public.rb @@ -1,3 +1,2 @@ class TypeDeChampPublic < TypeDeChamp - end diff --git a/app/services/browser_service.rb b/app/services/browser_service.rb index a11c030c1..0163bbe6e 100644 --- a/app/services/browser_service.rb +++ b/app/services/browser_service.rb @@ -1,5 +1,4 @@ class BrowserService - def self.get_browser request BROWSER.value = Browser.new(request.user_agent) end @@ -15,5 +14,4 @@ class BrowserService true end - end diff --git a/app/services/dossier_service.rb b/app/services/dossier_service.rb index d6bdaddfc..bdd2e85ca 100644 --- a/app/services/dossier_service.rb +++ b/app/services/dossier_service.rb @@ -1,5 +1,4 @@ class DossierService - def initialize dossier, siret, france_connect_information @dossier = dossier @siret = siret diff --git a/app/services/dossiers_list_gestionnaire_service.rb b/app/services/dossiers_list_gestionnaire_service.rb index b110fde11..e705f5662 100644 --- a/app/services/dossiers_list_gestionnaire_service.rb +++ b/app/services/dossiers_list_gestionnaire_service.rb @@ -186,5 +186,4 @@ class DossiersListGestionnaireService def current_preference_smart_listing_page @current_devise_profil.preference_smart_listing_page end - end diff --git a/app/services/france_connect_salt_service.rb b/app/services/france_connect_salt_service.rb index f1d766e44..ac64ccbf1 100644 --- a/app/services/france_connect_salt_service.rb +++ b/app/services/france_connect_salt_service.rb @@ -1,5 +1,4 @@ class FranceConnectSaltService - attr_reader :model def initialize france_connect_information diff --git a/app/services/notification_service.rb b/app/services/notification_service.rb index 27abe24cf..991120e95 100644 --- a/app/services/notification_service.rb +++ b/app/services/notification_service.rb @@ -1,5 +1,4 @@ class NotificationService - def initialize type_notif, dossier_id, attribut_change='' @type_notif = type_notif @dossier_id = dossier_id diff --git a/app/services/render_partial_service.rb b/app/services/render_partial_service.rb index efb5ed2ab..8e20fb8c6 100644 --- a/app/services/render_partial_service.rb +++ b/app/services/render_partial_service.rb @@ -1,5 +1,4 @@ class RenderPartialService - attr_accessor :controller, :method def initialize controller, method diff --git a/app/services/sync_credentials_service.rb b/app/services/sync_credentials_service.rb index 06d912b29..1319ae0d5 100644 --- a/app/services/sync_credentials_service.rb +++ b/app/services/sync_credentials_service.rb @@ -1,5 +1,4 @@ class SyncCredentialsService - def initialize klass, email_was, email, encrypted_password @klass = klass @email_was = email_was diff --git a/app/services/user_routes_authorization_service.rb b/app/services/user_routes_authorization_service.rb index 57b6f5af7..5507cdbbd 100644 --- a/app/services/user_routes_authorization_service.rb +++ b/app/services/user_routes_authorization_service.rb @@ -1,5 +1,4 @@ class UserRoutesAuthorizationService - def self.authorized_route? controller, dossier auth = controller.route_authorization diff --git a/app/uploaders/procedure_logo_uploader.rb b/app/uploaders/procedure_logo_uploader.rb index e5723f9a0..acce9da15 100644 --- a/app/uploaders/procedure_logo_uploader.rb +++ b/app/uploaders/procedure_logo_uploader.rb @@ -1,7 +1,6 @@ # encoding: utf-8 class ProcedureLogoUploader < BaseUploader - def root File.join(Rails.root, "public") end @@ -47,5 +46,4 @@ class ProcedureLogoUploader < BaseUploader def generate_secure_token SecureRandom.uuid end - end diff --git a/app/validators/email_format_validator.rb b/app/validators/email_format_validator.rb index 33f6b6065..bc9f01cb5 100644 --- a/app/validators/email_format_validator.rb +++ b/app/validators/email_format_validator.rb @@ -1,5 +1,4 @@ class EmailFormatValidator < ActiveModel::Validator - def email_regex /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i end diff --git a/app/validators/procedure_path_format_validator.rb b/app/validators/procedure_path_format_validator.rb index 2d677c37e..974f4c404 100644 --- a/app/validators/procedure_path_format_validator.rb +++ b/app/validators/procedure_path_format_validator.rb @@ -1,5 +1,4 @@ class ProcedurePathFormatValidator < ActiveModel::Validator - def path_regex /^[a-z0-9_]{3,30}$/ end @@ -8,5 +7,4 @@ class ProcedurePathFormatValidator < ActiveModel::Validator return false if record.path.blank? record.errors[:path] << "Path invalide" unless path_regex.match(record.path) end - end diff --git a/config/initializers/stringupcasepatch.rb b/config/initializers/stringupcasepatch.rb index 0c888e580..39d2e107a 100644 --- a/config/initializers/stringupcasepatch.rb +++ b/config/initializers/stringupcasepatch.rb @@ -1,9 +1,7 @@ require "unicode_utils/upcase" class String - def upcase UnicodeUtils.upcase(self) end - end diff --git a/db/migrate/20151207140202_update_module_api_carto.rb b/db/migrate/20151207140202_update_module_api_carto.rb index 0bb9b77ab..25549224d 100644 --- a/db/migrate/20151207140202_update_module_api_carto.rb +++ b/db/migrate/20151207140202_update_module_api_carto.rb @@ -1,11 +1,8 @@ class UpdateModuleAPICarto < ActiveRecord::Migration - class Procedure < ActiveRecord::Base - end class ModuleAPICarto < ActiveRecord::Base - end def up diff --git a/db/migrate/20160120094750_create_france_connect_information.rb b/db/migrate/20160120094750_create_france_connect_information.rb index 91b47ec10..1cea47245 100644 --- a/db/migrate/20160120094750_create_france_connect_information.rb +++ b/db/migrate/20160120094750_create_france_connect_information.rb @@ -1,11 +1,8 @@ class CreateFranceConnectInformation < ActiveRecord::Migration - class User < ActiveRecord::Base - end class FranceConnectInformation < ActiveRecord::Base - end def up diff --git a/db/migrate/20160317144949_piece_justificative_have_user.rb b/db/migrate/20160317144949_piece_justificative_have_user.rb index 10ee2b45b..23ddd81a3 100644 --- a/db/migrate/20160317144949_piece_justificative_have_user.rb +++ b/db/migrate/20160317144949_piece_justificative_have_user.rb @@ -8,7 +8,6 @@ class PieceJustificativeHaveUser < ActiveRecord::Migration end class User < ActiveRecord::Base - end def change diff --git a/db/migrate/20160317153115_cerfa_have_user.rb b/db/migrate/20160317153115_cerfa_have_user.rb index 7a0710901..a50cbf4c4 100644 --- a/db/migrate/20160317153115_cerfa_have_user.rb +++ b/db/migrate/20160317153115_cerfa_have_user.rb @@ -8,7 +8,6 @@ class CerfaHaveUser < ActiveRecord::Migration end class User < ActiveRecord::Base - end def change diff --git a/db/migrate/20160524093540_set_original_filename_for_uploaders.rb b/db/migrate/20160524093540_set_original_filename_for_uploaders.rb index d9d6306c6..bf8e700f2 100644 --- a/db/migrate/20160524093540_set_original_filename_for_uploaders.rb +++ b/db/migrate/20160524093540_set_original_filename_for_uploaders.rb @@ -1,10 +1,8 @@ class SetOriginalFilenameForUploaders < ActiveRecord::Migration class PieceJustificative < ActiveRecord::Base - end class Cerfa < ActiveRecord::Base - end def change diff --git a/db/migrate/20160609145737_delete_default_description_to_dossier.rb b/db/migrate/20160609145737_delete_default_description_to_dossier.rb index ded5122e7..8ba2fc7d9 100644 --- a/db/migrate/20160609145737_delete_default_description_to_dossier.rb +++ b/db/migrate/20160609145737_delete_default_description_to_dossier.rb @@ -1,18 +1,14 @@ class DeleteDefaultDescriptionToDossier < ActiveRecord::Migration class Dossier < ActiveRecord::Base - end class Champ < ActiveRecord::Base - end class Procedure < ActiveRecord::Base - end class TypeDeChamp < ActiveRecord::Base - end def up diff --git a/db/migrate/20160622081321_convert_all_datetime_to_date_on_database.rb b/db/migrate/20160622081321_convert_all_datetime_to_date_on_database.rb index 7d6d09bd0..2c61b98c2 100644 --- a/db/migrate/20160622081321_convert_all_datetime_to_date_on_database.rb +++ b/db/migrate/20160622081321_convert_all_datetime_to_date_on_database.rb @@ -1,7 +1,5 @@ class ConvertAllDatetimeToDateOnDatabase < ActiveRecord::Migration - class TypeDeChamp < ActiveRecord::Base - end def change diff --git a/db/migrate/20160803081304_fix_default_type_on_type_de_champ_table.rb b/db/migrate/20160803081304_fix_default_type_on_type_de_champ_table.rb index 01636f7c6..56120ef60 100644 --- a/db/migrate/20160803081304_fix_default_type_on_type_de_champ_table.rb +++ b/db/migrate/20160803081304_fix_default_type_on_type_de_champ_table.rb @@ -1,6 +1,5 @@ class FixDefaultTypeOnTypeDeChampTable < ActiveRecord::Migration class TypeDeChamp < ActiveRecord::Base - end def up diff --git a/db/migrate/20160804130638_add_type_attr_in_champ_table.rb b/db/migrate/20160804130638_add_type_attr_in_champ_table.rb index 465d9ce63..df21b33ea 100644 --- a/db/migrate/20160804130638_add_type_attr_in_champ_table.rb +++ b/db/migrate/20160804130638_add_type_attr_in_champ_table.rb @@ -1,5 +1,4 @@ class AddTypeAttrInChampTable < ActiveRecord::Migration - class TypeDeChamp < ActiveRecord::Base has_many :champs end diff --git a/db/migrate/20160822142045_delete_value_of_filter_procedure.rb b/db/migrate/20160822142045_delete_value_of_filter_procedure.rb index f541aefc9..9a369b8ed 100644 --- a/db/migrate/20160822142045_delete_value_of_filter_procedure.rb +++ b/db/migrate/20160822142045_delete_value_of_filter_procedure.rb @@ -1,6 +1,5 @@ class DeleteValueOfFilterProcedure < ActiveRecord::Migration class Gestionnaire < ActiveRecord::Base - end def change diff --git a/db/migrate/20160901082824_initiated_all_received_mail_for_procedure.rb b/db/migrate/20160901082824_initiated_all_received_mail_for_procedure.rb index 89e5f03cd..a2ccc89d9 100644 --- a/db/migrate/20160901082824_initiated_all_received_mail_for_procedure.rb +++ b/db/migrate/20160901082824_initiated_all_received_mail_for_procedure.rb @@ -4,7 +4,6 @@ class InitiatedAllReceivedMailForProcedure < ActiveRecord::Migration end class MailTemplate < ActiveRecord::Base - end class ::MailReceived < MailTemplate diff --git a/db/migrate/20160927154248_change_emptyto_nil_in_preference_list_dossier_table.rb b/db/migrate/20160927154248_change_emptyto_nil_in_preference_list_dossier_table.rb index a5905c8e2..e4203c62c 100644 --- a/db/migrate/20160927154248_change_emptyto_nil_in_preference_list_dossier_table.rb +++ b/db/migrate/20160927154248_change_emptyto_nil_in_preference_list_dossier_table.rb @@ -1,6 +1,5 @@ class ChangeEmptytoNilInPreferenceListDossierTable < ActiveRecord::Migration class PreferenceListDossier < ActiveRecord::Base - end def change diff --git a/db/migrate/20161004175442_fix_type_de_champ_header_section_with_mandatory_true.rb b/db/migrate/20161004175442_fix_type_de_champ_header_section_with_mandatory_true.rb index 945d4a910..23aec6f90 100644 --- a/db/migrate/20161004175442_fix_type_de_champ_header_section_with_mandatory_true.rb +++ b/db/migrate/20161004175442_fix_type_de_champ_header_section_with_mandatory_true.rb @@ -1,6 +1,5 @@ class FixTypeDeChampHeaderSectionWithMandatoryTrue < ActiveRecord::Migration class TypeDeChamp < ActiveRecord::Base - end def change diff --git a/db/migrate/20161007095443_reset_all_preference_list_dossier.rb b/db/migrate/20161007095443_reset_all_preference_list_dossier.rb index f4594bd5d..677ac4be6 100644 --- a/db/migrate/20161007095443_reset_all_preference_list_dossier.rb +++ b/db/migrate/20161007095443_reset_all_preference_list_dossier.rb @@ -143,7 +143,6 @@ class ResetAllPreferenceListDossier < ActiveRecord::Migration class Procedure < ActiveRecord::Base has_many :assign_to, dependent: :destroy has_many :gestionnaires, through: :assign_to - end def change diff --git a/spec/mailers/previews/avis_mailer_preview.rb b/spec/mailers/previews/avis_mailer_preview.rb index 55d153cd1..be78eae74 100644 --- a/spec/mailers/previews/avis_mailer_preview.rb +++ b/spec/mailers/previews/avis_mailer_preview.rb @@ -1,8 +1,6 @@ # Preview all emails at http://localhost:3000/rails/mailers/avis_mailer class AvisMailerPreview < ActionMailer::Preview - def avis_invitation AvisMailer.avis_invitation(Avis.last) end - end diff --git a/spec/mailers/previews/notification_mailer_preview.rb b/spec/mailers/previews/notification_mailer_preview.rb index 3cb6079a2..63691a2cd 100644 --- a/spec/mailers/previews/notification_mailer_preview.rb +++ b/spec/mailers/previews/notification_mailer_preview.rb @@ -1,7 +1,5 @@ class NotificationMailerPreview < ActionMailer::Preview - def send_notification NotificationMailer.send_notification(Dossier.last, Dossier.last.procedure.initiated_mail_template) end - end