From 1ffd4a230ba8f59d969f989af3e44a8146544737 Mon Sep 17 00:00:00 2001 From: gregoirenovel Date: Thu, 4 Oct 2018 18:48:33 +0200 Subject: [PATCH] Simplify RNAAdapter#process_params Avoid catching an attribute only to remove it a few lines later --- app/lib/api_entreprise/rna_adapter.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/lib/api_entreprise/rna_adapter.rb b/app/lib/api_entreprise/rna_adapter.rb index 227549518..10d19b603 100644 --- a/app/lib/api_entreprise/rna_adapter.rb +++ b/app/lib/api_entreprise/rna_adapter.rb @@ -12,11 +12,12 @@ class ApiEntreprise::RNAAdapter < ApiEntreprise::Adapter if !data_source.key?(:association) {} else + association_id = data_source[:association][:id] params = data_source[:association].slice(*attr_to_fetch) - if params[:id].present? && valid_params?(params) - params[:rna] = params[:id] - params.except(:id).transform_keys { |k| :"association_#{k}" } + if association_id.present? && valid_params?(params) + params[:rna] = association_id + params.transform_keys { |k| :"association_#{k}" } else {} end @@ -25,7 +26,6 @@ class ApiEntreprise::RNAAdapter < ApiEntreprise::Adapter def attr_to_fetch [ - :id, :titre, :objet, :date_creation,