From 157d1818b2917108b816402c310ecb80c22efaad Mon Sep 17 00:00:00 2001
From: Simon Lehericey <simon.lehericey@gmail.com>
Date: Mon, 10 Apr 2017 12:29:14 +0200
Subject: [PATCH] DescriptionController: move instance var to local var

---
 .../users/description_controller.rb           | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/app/controllers/users/description_controller.rb b/app/controllers/users/description_controller.rb
index 49664c5b6..af105cdcc 100644
--- a/app/controllers/users/description_controller.rb
+++ b/app/controllers/users/description_controller.rb
@@ -24,41 +24,41 @@ class Users::DescriptionController < UsersController
   end
 
   def update
-    @dossier = current_user_dossier
-    @procedure = @dossier.procedure
+    dossier = current_user_dossier
+    procedure = dossier.procedure
 
-    return head :forbidden unless @dossier.can_be_initiated?
+    return head :forbidden unless dossier.can_be_initiated?
 
-    @champs = @dossier.ordered_champs
+    @champs = dossier.ordered_champs
 
     check_mandatory_fields = !draft_submission?
 
     if params[:champs]
-      champs_service_errors = ChampsService.save_champs @dossier.champs,
+      champs_service_errors = ChampsService.save_champs dossier.champs,
                                                         params,
                                                         check_mandatory_fields
 
-      return redirect_to_description_with_errors(@dossier, champs_service_errors) if champs_service_errors.any?
+      return redirect_to_description_with_errors(dossier, champs_service_errors) if champs_service_errors.any?
     end
 
-    if @procedure.cerfa_flag? && params[:cerfa_pdf]
-      cerfa = Cerfa.new(content: params[:cerfa_pdf], dossier: @dossier, user: current_user)
-      return redirect_to_description_with_errors(@dossier, cerfa.errors.full_messages) unless cerfa.save
+    if procedure.cerfa_flag? && params[:cerfa_pdf]
+      cerfa = Cerfa.new(content: params[:cerfa_pdf], dossier: dossier, user: current_user)
+      return redirect_to_description_with_errors(dossier, cerfa.errors.full_messages) unless cerfa.save
     end
 
-    errors_upload = PiecesJustificativesService.upload!(@dossier, current_user, params)
-    return redirect_to_description_with_errors(@dossier, errors_upload) if errors_upload.any?
+    errors_upload = PiecesJustificativesService.upload!(dossier, current_user, params)
+    return redirect_to_description_with_errors(dossier, errors_upload) if errors_upload.any?
 
     if draft_submission?
       flash.notice = 'Votre brouillon a bien été sauvegardé.'
       redirect_to url_for(controller: :dossiers, action: :index, liste: :brouillon)
     else
-      if @dossier.draft?
-        @dossier.initiated!
-        NotificationMailer.send_notification(@dossier, @dossier.procedure.initiated_mail).deliver_now!
+      if dossier.draft?
+        dossier.initiated!
+        NotificationMailer.send_notification(dossier, procedure.initiated_mail).deliver_now!
       end
       flash.notice = 'Félicitations, votre demande a bien été enregistrée.'
-      redirect_to url_for(controller: :recapitulatif, action: :show, dossier_id: @dossier.id)
+      redirect_to url_for(controller: :recapitulatif, action: :show, dossier_id: dossier.id)
     end
   end