From 0a541d678d4d96f41b6adf9218f035dc957eb046 Mon Sep 17 00:00:00 2001 From: Pierre de La Morinerie Date: Wed, 3 Nov 2021 17:12:14 +0100 Subject: [PATCH] graphql_controller_spec: create several dossiers only when required Creating dossiers is faster than creating a procedure, but still slow. We can create a single dossier in the default case, and only create several others when the example requires it. Speeds up this spec from 0m 57s to 0m 49s. --- spec/controllers/api/v2/graphql_controller_spec.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/spec/controllers/api/v2/graphql_controller_spec.rb b/spec/controllers/api/v2/graphql_controller_spec.rb index 855d66361..e88feeac8 100644 --- a/spec/controllers/api/v2/graphql_controller_spec.rb +++ b/spec/controllers/api/v2/graphql_controller_spec.rb @@ -5,8 +5,7 @@ describe API::V2::GraphqlController do let(:dossier) { create(:dossier, :en_construction, :with_individual, procedure: procedure) } let(:dossier1) { create(:dossier, :en_construction, :with_individual, procedure: procedure, en_construction_at: 1.day.ago) } let(:dossier2) { create(:dossier, :en_construction, :with_individual, :archived, procedure: procedure, en_construction_at: 3.days.ago) } - #let(:dossiers) { [dossier2, dossier1, dossier] } - let(:dossiers) { [dossier2, dossier1, dossier] } + let(:dossiers) { [dossier] } let(:instructeur) { create(:instructeur, followed_dossiers: dossiers) } def compute_checksum_in_chunks(io) @@ -162,6 +161,8 @@ describe API::V2::GraphqlController do end describe "filter dossiers" do + let(:dossiers) { [dossier, dossier1, dossier2] } + let(:query) do "{ demarche(number: #{procedure.id}) { @@ -189,6 +190,7 @@ describe API::V2::GraphqlController do end describe "filter archived dossiers" do + let(:dossiers) { [dossier, dossier1, dossier2] } let(:query) do "{ demarche(number: #{procedure.id}) { @@ -911,6 +913,7 @@ describe API::V2::GraphqlController do end describe 'dossierPasserEnInstruction' do + let(:dossiers) { [dossier2, dossier1, dossier] } let(:dossier) { create(:dossier, :en_construction, :with_individual, procedure: procedure) } let(:instructeur_id) { instructeur.to_typed_id } let(:disable_notification) { false }