From 073656342e5b72c217d3beec10b4376e1c2b1789 Mon Sep 17 00:00:00 2001
From: Colin Darie <colin@darie.eu>
Date: Tue, 11 Oct 2022 11:13:04 +0200
Subject: [PATCH] fix(api_address): support Adresse BAN without postcode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Des adresses n'ont pas de code postal (dans certains TOM par exemple).
On fallback sur un string vide plutôt que nil pour limiter les effets de bord.
---
 app/lib/api_address/address_adapter.rb       |  2 +-
 app/schemas/adresse-ban.json                 |  2 +-
 spec/lib/api_address/address_adapter_spec.rb | 16 +++++++++++++---
 3 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/app/lib/api_address/address_adapter.rb b/app/lib/api_address/address_adapter.rb
index d121479e1..7f9d406ab 100644
--- a/app/lib/api_address/address_adapter.rb
+++ b/app/lib/api_address/address_adapter.rb
@@ -22,7 +22,7 @@ class APIAddress::AddressAdapter
           street_address: result.street_address,
           street_number: result.street_number,
           street_name: result.street_name,
-          postal_code: result.postal_code,
+          postal_code: result.postal_code.presence || "",
           city_name: result.city_name,
           city_code: result.city_code,
           department_name: result.department_name,
diff --git a/app/schemas/adresse-ban.json b/app/schemas/adresse-ban.json
index ccb236b5d..6c64224f1 100644
--- a/app/schemas/adresse-ban.json
+++ b/app/schemas/adresse-ban.json
@@ -19,7 +19,7 @@
           "enum": ["housenumber", "street", "locality", "municipality"]
         }
       },
-      "required": ["label", "type", "name", "postcode", "citycode", "city"]
+      "required": ["label", "type", "name", "citycode", "city"]
     },
     "geometry": {
       "type": "object",
diff --git a/spec/lib/api_address/address_adapter_spec.rb b/spec/lib/api_address/address_adapter_spec.rb
index 1655e731b..55ff5b1ea 100644
--- a/spec/lib/api_address/address_adapter_spec.rb
+++ b/spec/lib/api_address/address_adapter_spec.rb
@@ -1,6 +1,7 @@
 describe APIAddress::AddressAdapter do
   let(:search_term) { 'Paris' }
   let(:adapter) { described_class.new(search_term) }
+  let(:status) { 200 }
   subject { adapter.to_params }
 
   before do
@@ -15,7 +16,6 @@ describe APIAddress::AddressAdapter do
 
   context "when responds with valid schema" do
     let(:body) { File.read('spec/fixtures/files/api_address/address.json') }
-    let(:status) { 200 }
 
     it '#to_params returns a valid' do
       expect(subject).to be_an_instance_of(Hash)
@@ -26,7 +26,6 @@ describe APIAddress::AddressAdapter do
 
   context "when responds with an address which is not a direct match to search term" do
     let(:body) { File.read('spec/fixtures/files/api_address/address.json') }
-    let(:status) { 200 }
     let(:search_term) { 'Lyon' }
 
     it '#to_params ignores the response' do
@@ -36,10 +35,21 @@ describe APIAddress::AddressAdapter do
 
   context "when responds with invalid schema" do
     let(:body) { File.read('spec/fixtures/files/api_address/address_invalid.json') }
-    let(:status) { 200 }
 
     it '#to_params raise exception' do
       expect { subject }.to raise_exception(APIAddress::AddressAdapter::InvalidSchemaError)
     end
   end
+
+  context "when responds without postcode" do
+    let(:body) {
+      json = JSON.parse(File.read('spec/fixtures/files/api_address/address.json'))
+      json["features"][0]["properties"].delete("postcode")
+      json.to_json
+    }
+
+    it "#to_params default to an empty postcode" do
+      expect(subject[:postal_code]).to eq("")
+    end
+  end
 end