From 03559eec0be4e87adaf0aabfdb410fa6e94475b3 Mon Sep 17 00:00:00 2001 From: gregoirenovel Date: Tue, 27 Feb 2018 16:08:38 +0100 Subject: [PATCH] Remove some footer voodoo to simplify things --- app/assets/stylesheets/new_design/_constants.scss | 5 ----- app/assets/stylesheets/new_design/common.scss | 9 --------- app/assets/stylesheets/new_design/new_footer.scss | 6 ------ app/views/layouts/new_application.html.haml | 2 +- 4 files changed, 1 insertion(+), 21 deletions(-) diff --git a/app/assets/stylesheets/new_design/_constants.scss b/app/assets/stylesheets/new_design/_constants.scss index f652937cc..0c9aaf6c7 100644 --- a/app/assets/stylesheets/new_design/_constants.scss +++ b/app/assets/stylesheets/new_design/_constants.scss @@ -3,11 +3,6 @@ $page-width: 1040px; $default-spacer: 8px; $default-padding: 2 * $default-spacer; -$footer-height: 267px; -$footer-height-mobile: 531px; - -$small-footer-height: 2 * $default-padding; - // layouts $two-columns-padding: 60px; $two-columns-breakpoint: $page-width + (2 * $two-columns-padding); diff --git a/app/assets/stylesheets/new_design/common.scss b/app/assets/stylesheets/new_design/common.scss index 5901a5db6..e98f7270c 100644 --- a/app/assets/stylesheets/new_design/common.scss +++ b/app/assets/stylesheets/new_design/common.scss @@ -15,16 +15,7 @@ select { .page-wrapper { position: relative; - padding-bottom: $small-footer-height; min-height: 100%; - - &.with-footer { - padding-bottom: $footer-height; - - @media (max-width: 1000px) { - padding-bottom: $footer-height-mobile; - } - } } h1 { diff --git a/app/assets/stylesheets/new_design/new_footer.scss b/app/assets/stylesheets/new_design/new_footer.scss index 5f34bc894..eb451c5bb 100644 --- a/app/assets/stylesheets/new_design/new_footer.scss +++ b/app/assets/stylesheets/new_design/new_footer.scss @@ -7,14 +7,8 @@ footer { @include vertical-padding(72px); background-color: $light-grey; border-top: 1px solid $border-grey; - position: absolute; bottom: 0; width: 100%; - height: $footer-height; - - @media (max-width: 1000px) { - height: $footer-height-mobile; - } } .footer-columns { diff --git a/app/views/layouts/new_application.html.haml b/app/views/layouts/new_application.html.haml index 973899ddf..dcccd8024 100644 --- a/app/views/layouts/new_application.html.haml +++ b/app/views/layouts/new_application.html.haml @@ -17,7 +17,7 @@ = stylesheet_link_tag "new_design/print", media: "print", "data-turbolinks-track": true %body - .page-wrapper{ class: content_for?(:display_footer) ? 'with-footer' : 'nil' } + .page-wrapper = render partial: "layouts/support_navigator_banner" = render partial: "layouts/ie_lt_10" - if Rails.env == "staging"