From 73cf73157cf178341f752065654ab24c66205111 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20P=C3=A9pin?= Date: Sat, 20 Jun 2020 17:45:39 +0200 Subject: [PATCH] More relevant tests for register_cas_account --- authens/tests/test_shortcuts.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/authens/tests/test_shortcuts.py b/authens/tests/test_shortcuts.py index 3c2a16b..307eb42 100644 --- a/authens/tests/test_shortcuts.py +++ b/authens/tests/test_shortcuts.py @@ -25,13 +25,18 @@ class TestRegisterCasAccount(TestCase): self.assertEqual(user.cas_account.entrance_year, 2019) def test_cant_register_twice(self): - user = User.objects.create_user(username="whatever") - CASAccount.objects.create(user=user, cas_login="johndoe", entrance_year=2019) + john = User.objects.create_user(username="whatever") + CASAccount.objects.create(user=john, cas_login="johndoe", entrance_year=2019) + janis = User.objects.create_user(username="janisjoplin") + + # John cannot have two CAS accounts with self.assertRaises(ValueError): - register_cas_account(user, cas_login="johndoe") + register_cas_account(john, cas_login="joplin") + + # Janis cannot steal John's account with self.assertRaises(ValueError): - register_cas_account(user, cas_login="janisjoplin") + register_cas_account(janis, cas_login="johndoe") self.assertEqual(CASAccount.objects.count(), 1) @@ -41,7 +46,5 @@ class TestRegisterCasAccount(TestCase): with self.assertRaises(ValueError): register_cas_account(user, cas_login="toto") - with self.assertRaises(ValueError): - register_cas_account(user, cas_login="ninasimone") self.assertFalse(CASAccount.objects.exists())