From 351b084419d5d370e6c164c0b6189a10d5a5f543 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20P=C3=A9pin?= Date: Sat, 20 Jun 2020 17:25:57 +0200 Subject: [PATCH] Handle non-existing users in register_cas_account --- authens/shortcuts.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/authens/shortcuts.py b/authens/shortcuts.py index a4f5e1c..8a8dd97 100644 --- a/authens/shortcuts.py +++ b/authens/shortcuts.py @@ -59,7 +59,11 @@ def register_cas_account(user: User, cas_login: str) -> CASAccount: if OldCASAccount.objects.filter(user=user).exists(): raise ValueError("User '{}' has an old CAS account".format(user)) - entrance_year = fetch_cas_account(cas_login)["entrance_year"] + ldap_info = fetch_cas_account(cas_login) + if ldap_info is None: + raise ValueError("There is no LDAP user for id '{}'".format(cas_login)) + + entrance_year = ldap_info["entrance_year"] return CASAccount.objects.create( user=user, cas_login=cas_login, entrance_year=entrance_year )